(feat) allow Arc wrapped value as middleware #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reem
added a commit
that referenced
this pull request
May 20, 2015
(feat) allow Arc wrapped value as middleware
|
Sounds good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was working on live-reload feature on my handlebars-iron middleware. In order to watch the file system and reload template engine, I spawned a dedicated thread waiting for fs events. The middleware is shared in main thread and watcher thread. So I made it wrapped by Arc.
I hope iron could accept Arc wrapped value as
BeforeMiddlewareandAfterMiddleware. Otherwise, it seems difficult to set an Arc into Chain.The code with modified iron is here:
https://github.com/sunng87/handlebars-iron/blob/feature/notify/examples/watch_server.rs#L50
If there is a better solution for this scenario, please kindly let me know. :-)