Added field to print the request time. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the {request-time} field which prints the time when the
request ocurred using the format "%Y-%m-%dT%H:%M:%S.%fZ%z".
Fix #69
Hoverbear
reviewed
Oct 14, 2016
| @@ -29,7 +29,7 @@ impl Logger { | |||
| /// Create a pair of `Logger` middlewares with the specified `format`. If a `None` is passed in, uses the default format: | |||
| /// | |||
| /// ```ignore | |||
| /// {method} {uri} -> {status} ({response_time} ms) | |||
| /// {method} {uri} -> {status} ({response-time} ms) | |||
Hoverbear
reviewed
Oct 14, 2016
| @@ -48,18 +48,18 @@ impl Logger { | |||
| } | |||
|
|
|||
| struct StartTime; | |||
| impl Key for StartTime { type Value = time::Instant; } | |||
| impl Key for StartTime { type Value = time::Tm; } | |||
There was a problem hiding this comment.
Are these changes to StartTime (and the ones below) required for this PR? Otherwise I'd prefer to see them in another PR.
There was a problem hiding this comment.
The problem with time::Instant is that it doesn't have a format function.
It may be because I don't understand Rust 100% yet but I can't find a way to do it without time::Tm.
Hoverbear
reviewed
Oct 14, 2016
| @@ -11,3 +11,4 @@ license = "MIT" | |||
| [dependencies] | |||
| iron = { version = "0.4", default-features = false } | |||
| term = "0.4" | |||
| time = "0.1.35" | |||
There was a problem hiding this comment.
Looks like std::time exists now. https://doc.rust-lang.org/std/time. However I'm not sure it did at the time of this PR. :)
|
Hey! Sorry it took so long to get around to this! Let's get this merged, it's on my radar now! |
Hoverbear
approved these changes
Oct 14, 2016
|
Thanks so much for your contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the {request-time} field which prints the time when the
request ocurred using the format "%Y-%m-%dT%H:%M:%S.%fZ%z".
Fix #69