Version bump for Serde? #68

alanhdu · 2017-03-10T21:56:13Z

urlencoded depends on bodyparser 0.5, which depends on serde 0.8. Would it be possible to cut a new release that uses bodyparser 0.6 instead (which would let us use serde 0.9 without weird type mismatches)?

The text was updated successfully, but these errors were encountered:

euclio · 2017-04-25T13:46:13Z

bodyparser has been bumped again in #70 to pull in serde 1.0. @untitaker, are you in charge of releases?

Hoverbear · 2017-06-22T05:56:29Z

@euclio Unfortunately I can't release this. Maybe @SkylerLipthay or @reem could.

durka · 2017-08-08T21:32:31Z

Is this package maintained? We could release it under a new name...

Hoverbear · 2017-08-09T07:20:21Z

@durka Yes. Myself, @reem, @untitaker, and @SkylerLipthay . However there are still some permissions issues around who can publish what on crates.io. This was already clearly stated.

durka · 2017-08-09T15:45:32Z

@Hoverbear I apologize for the flippant tone, which was unwarranted. I was just trying to make some noise since it seems like none of those with said permissions have been paying attention. It looks like @michaelsproul and @theptrk are the other two people with crates.io rights?

Hoverbear · 2017-08-09T17:59:32Z

Hopefully one of them can help. :)

untitaker · 2017-08-09T18:23:29Z

I suppose 0.6.0 is the next version? Or do we not expose this dependency?

…

On Wed, Aug 09, 2017 at 10:59:32AM -0700, Andrew Hobden wrote: Hopefully one of them can help. :) -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #68 (comment)

durka · 2017-08-09T18:41:03Z

It's 0.7 now (for serde 1.0). Maybe a serde 0.9 version of urlencoded should be released as well though, in case anyone still needs it to harmonize their dependencies.

michaelsproul · 2017-08-09T22:20:22Z

Hi all, I'd love to help, and although it seems I'm listed in Cargo.toml's authors field for my meagre contributions, I'm not a crate owner on crates.io and can't publish. However, it looks like everyone in the iron-dev team can publish: https://github.com/orgs/iron/teams/dev-team/members, which includes a bunch of people here :)

Cargo docs on publishing for reference: http://doc.crates.io/crates-io.html

Good luck!

Manishearth · 2017-08-11T22:20:41Z

Oh, we had this issue recently too in Servo. Does this org have crates.io as an approved OAuth app?

Because if it doesn't then crates.io will silently ignore the dev-team stuff.

What I suggest is you go to your settings and revoke permission from crates.io. Then log in to the site again -- at that point you see which orgs have approved it, and are given the ability to approve it for orgs you manage, or request approval for orgs which you are a part of but don't manage. If you're in the last bucket you can ask the Iron org owners to approve it from settings after you put in the request.

untitaker · 2017-08-12T13:52:41Z

@Manishearth it was always approved before, I re-authed as you instructed and nothing happens. I don't understand why @Hoverbear doesn't have access to publish a new version.

the iron doesn't have any application restrictions at all, so apps wouldn't need explicit approval.

@Hoverbear please try if any of the advice by @michaelsproul and @Manishearth helps, otherwise I'll just push a new version.

robinst · 2017-09-26T01:11:37Z

@untitaker: To try to move this along, can you add some others explicitly as owners for this crate, like this?:

cargo owner --add Hoverbear
cargo owner --add michaelsproul

Then they can try to see if they have more luck with adding the whole team as owners. Maybe removing the team and adding it again helps (not sure if the name is dev-team or iron-dev?):

cargo owner --remove github:iron:dev-team
cargo owner --add github:iron:dev-team

untitaker · 2017-10-01T19:24:43Z

I added @Hoverbear @michaelsproul @sfackler as owner for this crate, however, when trying your second set of commands I get an error when trying to re-add the team:

$ cargo owner --add github:iron:dev-team                   
    Updating registry `https://github.com/rust-lang/crates.io-index`                                                   
       Owner adding ["github:iron:dev-team"] to crate urlencoded                                                       
error: failed to add owners to crate urlencoded: api errors: only members of github:iron:dev-team can add it as an owner

Manishearth · 2017-10-01T22:43:54Z

An org admin will need to reauth Crates.io.

The way you do this is by removing Crates.io from your approved applications for your personal account, and then trying to log in to the site again, at which point it will ask you to authorize crates.io, and will give you the option to authorize it for organizations you have access to; or to request access from the admins.

There's probably a better way to do it, I just don't know what.

untitaker · 2017-10-02T04:02:15Z

Crates.io is already authorized for the org, as i am admin

…

On 2 October 2017 00:43:55 GMT+02:00, Manish Goregaokar ***@***.***> wrote: An org admin will need to reauth Crates.io. The way you do this is by removing Crates.io from your approved applications for your personal account, and then trying to log in to the site again, at which point it will ask you to authorize crates.io, and will give you the option to authorize it for organizations you have access to; or to request access from the admins. There's probably a better way to do it, I just don't know what. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #68 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

Manishearth · 2017-10-02T04:03:48Z

as i am admin

note that just being an admin and giving personal access to crates will not authorize it for the org as well. these are separate permissions systems.

untitaker · 2017-10-02T07:36:11Z

The org doesn't have any additional protections:

robinst · 2017-10-02T23:17:32Z

@untitaker can you add @Manishearth as an admin of the iron organization so he can have a look?

untitaker · 2017-10-03T05:59:43Z

done

…

On Mon, Oct 02, 2017 at 11:17:32PM +0000, Robin Stocker wrote: @untitaker can you add @Manishearth as an admin of the iron organization so he can have a look? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #68 (comment)

Manishearth · 2017-10-03T15:24:21Z

Hm, I can't either, since I don't have owner access on crates.io. But you're right, it should work. Perhaps try cargo owner -a iron:dev-team?

untitaker · 2017-10-03T18:50:10Z

That doesn't work either, cargo rejects the format of `iron:dev-team` very early.

…

On Tue, Oct 03, 2017 at 03:24:22PM +0000, Manish Goregaokar wrote: Hm, I can't either, since I don't have owner access on crates.io. But you're right, it should work. Perhaps try `cargo owner -a iron:dev-team`? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #68 (comment)

robinst · 2017-10-03T18:59:52Z

@untitaker can you add @Manishearth as an owner to the crate?:

cargo owner --add Manishearth

untitaker · 2017-10-03T19:00:31Z

done

Manishearth · 2017-10-03T20:05:55Z

Interesting, I get the same error, but not the same error when I try to add servo:cargo-publish.

It's also not an oauth restriction thing -- I even flipped on restrictions and authorized crates.io and it still didn't work.

Manishearth · 2017-10-03T20:45:51Z

Turns out this is a Cargo bug wrt team ids, it's being fixed.

robinst · 2017-10-04T19:03:15Z

@Manishearth: Yay! Do you have a link to an issue/PR?

Manishearth · 2017-10-04T19:05:21Z

rust-lang/crates.io#1107

(@carols10cents is amazing)

robinst · 2017-10-18T04:19:27Z

Yay! Looks like the fix was merged. @Manishearth, does adding the team work now?

remram44 · 2017-10-18T04:26:20Z

I'm excited for Iron to make a comeback in the active web frameworks! This release has been delayed over 6 months already, hopefully Cargo is fixed and we won't see this happen again 😅

Manishearth · 2017-10-18T05:23:13Z

it worked!

robinst · 2017-10-18T18:30:27Z

Yay! So maybe also run the command on all the other iron crates, just to make sure.

Also, who wants to do the releasing now? (I'm willing to help by the way, but someone would need to add me to the list of maintainers.)

Manishearth · 2017-10-18T20:44:57Z

(I'm only an owner for this crate, need @untitaker to look at the others)

I tried cargo-publishing this crate, it's already published

durka · 2017-10-18T23:54:38Z

@Manishearth the minor version number needs to be bumped (the change motivating this issue, bumping the bodyparser dep, has already been committed).

untitaker · 2017-10-19T20:18:31Z

Whichever crate I try, I get the error message that the GitHub org is already an owner.

…

On Wed, Oct 18, 2017 at 08:44:57PM +0000, Manish Goregaokar wrote: (I'm only an owner for this crate, need @untitaker to look at the others) I tried cargo-publishing this crate, it's already published -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #68 (comment)

untitaker · 2017-10-19T20:18:42Z

Please ping me if a particular repo is missing.

…

On Wed, Oct 18, 2017 at 08:44:57PM +0000, Manish Goregaokar wrote: (I'm only an owner for this crate, need @untitaker to look at the others) I tried cargo-publishing this crate, it's already published -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #68 (comment)

robinst · 2017-10-19T21:06:56Z

Cool, so maybe it fixed it for all crates :).

So, who is going to release all the things that need releasing? Seems like that is at least this crate and iron itself.

euclio · 2017-11-02T16:21:10Z

iron/params will need to bump this crate and release as well

untitaker · 2017-11-05T12:59:40Z

Done!

est31 · 2017-11-19T04:28:05Z

It would be really cool if a new version could be released that includes #70 because that hasn't happened yet! I don't want to pull in pre 1.0 serde :)

Manishearth · 2017-11-19T04:43:20Z

Oh, I thought this was published. My bad.

Manishearth · 2017-11-19T04:43:54Z

@untitaker can you bump the version in this repo and republish? I can do it too but not at the moment

robinst · 2017-11-19T07:34:34Z

body-parser needs to be released first: iron/body-parser#79

See this issue in iron for all dependencies and the order: iron/iron#551

iori-yja · 2017-11-19T17:19:01Z

This refers the iron/body-parser#79 's version→ #72
The build is failed because the version is not released yet ... But I confirmed on my local test with the modification, if my memory is correct.

untitaker · 2017-11-21T12:13:38Z

body-parser is now released.

robinst · 2017-11-23T03:23:46Z

urlencoded 0.6.0 has been released, which depends on bodyparser 0.8, which depends on serde 1.0. So I think we can close this now.

est31 · 2017-11-23T05:10:52Z

Thanks! Now I do need a new release of staticfile however because you also switched to iron 0.6.0...

robinst · 2017-11-23T05:37:26Z

@est31: The iron dependency has the constraints >= 0.5, <0.7, so in theory it should still work with 0.5.0. Have you tried?

est31 · 2017-11-23T05:51:39Z

Oh that's interesting... Yep it works. Thank you @robinst !

paradoxix mentioned this issue Mar 14, 2017

(feat) update bodyparser dependency 0.5 -> 0.6 #69

Merged

euclio mentioned this issue Jun 21, 2017

update serde and bodyparser iron/params#35

Closed

robinst mentioned this issue Sep 26, 2017

Release 0.6.0 with changes on master iron/iron#551

Closed

9 tasks

Manishearth closed this as completed Nov 19, 2017

Manishearth reopened this Nov 19, 2017

Manishearth closed this as completed Nov 23, 2017

Version bump for Serde? #68

Version bump for Serde? #68

Comments

alanhdu commented Mar 10, 2017

euclio commented Apr 25, 2017

Hoverbear commented Jun 22, 2017

durka commented Aug 8, 2017

Hoverbear commented Aug 9, 2017 • edited Loading

durka commented Aug 9, 2017

Hoverbear commented Aug 9, 2017

untitaker commented Aug 9, 2017 via email

durka commented Aug 9, 2017

michaelsproul commented Aug 9, 2017

Manishearth commented Aug 11, 2017

untitaker commented Aug 12, 2017

robinst commented Sep 26, 2017

untitaker commented Oct 1, 2017

Manishearth commented Oct 1, 2017

untitaker commented Oct 2, 2017 via email

Manishearth commented Oct 2, 2017

untitaker commented Oct 2, 2017

robinst commented Oct 2, 2017

untitaker commented Oct 3, 2017 via email

Manishearth commented Oct 3, 2017

untitaker commented Oct 3, 2017 via email

robinst commented Oct 3, 2017

untitaker commented Oct 3, 2017

Manishearth commented Oct 3, 2017 • edited Loading

Manishearth commented Oct 3, 2017

robinst commented Oct 4, 2017

Manishearth commented Oct 4, 2017

robinst commented Oct 18, 2017

remram44 commented Oct 18, 2017

Manishearth commented Oct 18, 2017

robinst commented Oct 18, 2017

Manishearth commented Oct 18, 2017

durka commented Oct 18, 2017 • edited Loading

untitaker commented Oct 19, 2017 via email

untitaker commented Oct 19, 2017 via email

robinst commented Oct 19, 2017

euclio commented Nov 2, 2017

untitaker commented Nov 5, 2017

est31 commented Nov 19, 2017

Manishearth commented Nov 19, 2017

Manishearth commented Nov 19, 2017

robinst commented Nov 19, 2017

iori-yja commented Nov 19, 2017 • edited Loading

untitaker commented Nov 21, 2017

robinst commented Nov 23, 2017

est31 commented Nov 23, 2017

robinst commented Nov 23, 2017

est31 commented Nov 23, 2017

Hoverbear commented Aug 9, 2017 •

edited

Loading

Manishearth commented Oct 3, 2017 •

edited

Loading

durka commented Oct 18, 2017 •

edited

Loading

iori-yja commented Nov 19, 2017 •

edited

Loading