[JBJCA-1341] Account for additional DB2 FATAL connection errors #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it should trim both messages, from Exception and from StringTokenizer. Also I think contains won't work now as configured messages are changed to upper case. Also contains can match two different messages with the same base, I think it would be better to use equals |
|
I see. Trimming shouldn't make a difference since contains won't care for trailing spaces, the custom messages will already being trimmed. About the upper case, you are right. Let me refresh this. |
Issue: https://issues.jboss.org/browse/JBJCA-1341 I refactored the code a bit to make it less prone to issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.jboss.org/browse/JBJCA-1341
I refactored the code a bit to make it less prone to issues.