Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBJCA-1427] user and password should be copied to the properties if they are specified #733

Merged

Conversation

gaol
Copy link
Contributor

@gaol gaol commented Jul 29, 2021

Issue: https://issues.redhat.com/browse/JBJCA-1427
EAP Issue: https://issues.redhat.com/browse/JBEAP-22286

When DataSource.getConnection(username, password) is called, it should use username/password specified in the method call instead of using kerberos username.

@gaol gaol changed the title uSet user and password properties if they are specified Set user and password properties if they are specified Jul 29, 2021
@gaol
Copy link
Contributor Author

gaol commented Jul 29, 2021

@tadamski would you please review? thanks :)

@rmartinc
Copy link

@gaol I have tested the PR and it's working in the QA environment.

@gaol gaol force-pushed the no_copy_kerberos_only_no_request_info branch from 1f2b95f to 4b5e411 Compare July 30, 2021 06:02
@gaol gaol changed the title Set user and password properties if they are specified [JBJCA-1427] user and password should be copied to the properties if they are specified Jul 30, 2021
@tadamski tadamski merged commit 7638017 into ironjacamar:1.4 Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants