Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update sensor_name after resolving hostname #144

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

kroecks
Copy link
Contributor

@kroecks kroecks commented Mar 18, 2024

My pi's weren't registering correctly and I was getting a lot of MQTT traffic with rpi_{hostname}.
This is because the "default_sensor_name" is not the same as the MQTT.sensor_name config, and yet the default sensor name is being used to validate whether to set the hostname.

Until the logic for reconciling the MQTT config and the default sensor name is more meaningful, it's better to just ALWAYS set the sensor name correctly.

@ironsheep ironsheep self-assigned this Apr 22, 2024
@ironsheep ironsheep merged commit 35a9fc5 into ironsheep:master Apr 24, 2024
@ironsheep
Copy link
Owner

Thank you, Ken, for spotting this. This issue has been plaguing many of us. I appreciate your taking the time to file this PR! -Stephen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants