Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set Tokaido to use pinned image tags, rather than 'edge' or 'stable' #203

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

ironmike-au
Copy link
Contributor

With this PR, Tokaido will use specific Docker image tags that correspond to that Tokaido release.

For example, Tokaido 1.11.0 will use Docker Images tagged 1.11.0.

We will still have the concept of "edge" and "stable" releases, as matched against which version of Tokaido is running in the Ironstar prod and non-prod clusters.

This change enables us to remove the docker-pull functionality which takes unnecessary time during up, and will also enable us to offer more consistency between Tokaido versions.

@ironmike-au ironmike-au self-assigned this Oct 13, 2019
@ironmike-au ironmike-au added the enhancement New feature or request label Oct 13, 2019
@ironmike-au ironmike-au added this to the 1.11.0 milestone Oct 13, 2019
Copy link
Contributor

@jimmycann jimmycann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A positive change, but could this break people when upgrading Tokaido? Could end up being an unintended deterrent. We may need to consider the ability for our users to upgrade Tokaido and their containers asynchronously, without having to use custom compose file.

@ironmike-au ironmike-au merged commit 999a0b3 into develop Oct 13, 2019
@ironmike-au
Copy link
Contributor Author

A positive change, but could this break people when upgrading Tokaido? Could end up being an unintended deterrent. We may need to consider the ability for our users to upgrade Tokaido and their containers asynchronously, without having to use custom compose file.

I'd like to move us to a google cloud model of auto-updating, where each time the user runs, if there's an update, they get prompted to instal lit there and then. It's much quicker and easier than using homebrew, which it turns out most people don't update at all.

This should encourage people on to newer versions. At the same time, we can look at making it easy to roll back to previous container versions.

@ironmike-au ironmike-au deleted the feature/pinned-image-versions branch October 13, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants