Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some colors combinations are hard to read #23

Closed
Kaian opened this issue Feb 12, 2015 · 7 comments
Closed

Some colors combinations are hard to read #23

Kaian opened this issue Feb 12, 2015 · 7 comments

Comments

@Kaian
Copy link
Member

Kaian commented Feb 12, 2015

Due to #21 some colors have changed making it harder to read some sections (like titles, keybindings and columns headers).

Restore old color values keeping it also readable by monochrome terminals.

Kaian added a commit that referenced this issue Feb 12, 2015
@Kaian
Copy link
Member Author

Kaian commented Feb 12, 2015

@ssinyagin if you have time, would you mind to give it a try to new_monochrome branch?

Thanks in advance!

@ssinyagin
Copy link

ssinyagin commented Feb 12, 2015 via email

@Kaian
Copy link
Member Author

Kaian commented Feb 12, 2015

Thanks!, some coworker reported me some colors have changed due to the monochrome fixes.
Of course, this is not critical but I would like to make both color/monochrome users happy.

Kaian added a commit that referenced this issue Feb 12, 2015
@Kaian
Copy link
Member Author

Kaian commented Feb 16, 2015

I was able to test this branch using

TERM=vt100 sngrep

Colors seem fine, but screen is not cleared after exiting sngrep

@ssinyagin
Copy link

ssinyagin commented Feb 16, 2015 via email

@Kaian
Copy link
Member Author

Kaian commented Feb 16, 2015

With the last change, the screen is cleared in vt100 and it preserves the normal behaviour in color terminals (just returning to the last prompt status).

I'll merge this. If any monochrome user find it strange to have the screen cleared after exiting, we'll review this change.

@Kaian Kaian closed this as completed Feb 16, 2015
@Kaian
Copy link
Member Author

Kaian commented Feb 16, 2015

Thanks for the testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants