Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection not visible in monochrome terminal #21

Closed
ssinyagin opened this issue Feb 6, 2015 · 7 comments
Closed

selection not visible in monochrome terminal #21

ssinyagin opened this issue Feb 6, 2015 · 7 comments
Assignees
Labels
Milestone

Comments

@ssinyagin
Copy link

hi again
in SecureCRT in monchrome mode, the selection is not visible on the overview screen. I will test in more detail later tonight.

@Kaian
Copy link
Member

Kaian commented Feb 6, 2015

Also, try with the option set background dark in the sngreprc file (in /etc/ or your system dir)

You can change this option only for your user in $HOME/.sngreprc file.

Most of the testing is done with terminals with color enabled, so a screenshoot will be appreciated.

Thanks!

@Kaian
Copy link
Member

Kaian commented Feb 6, 2015

I was able to reproduce this issue disabling ncurses color mode.

There are still parts that are not properly drawn (like colum headers, titles and keybindings), but at least now it can be used.

If you can, give it a try to fix_monochrome branch.

@ssinyagin
Copy link
Author

yes, now it works fine in monochrome.

Another issue: the output doesn't fit into 132 columns (standard wide terminal size), and completely broken in 80 columns (standard terminal size). I think it makes sense to fit it into 132 columns, and print an error if the terminal is 80 symbols wide.

Also, "destiny" has a completely different meaning than "destination". I think it's better to cut it to "dest".

@Kaian
Copy link
Member

Kaian commented Feb 7, 2015

I try to avoid width restriction (initially set to 120 columns in v0.0.0).

Even with very little space on screen, users can configure what columns want to fit in that space in sngreprc file (maybe method, from and msg count is enough for them)
In Call flow , Raw preview panel can toggled, so at least two or three address columns can be displayed. Displayed columns width can also be configured in sngreprc.

If you provide some screenshots, I may distinguish between broken or not properly configured for your terminal width :)

About "destiny"... Oops! The proper column name should be Destination I guess. It's title width, again, will be the one configured in sngrep file, which by default is enough to fit all the word without abbreviation.

Thanks a lot for the feedback!

@Kaian
Copy link
Member

Kaian commented Feb 7, 2015

I have changed first two columns width to 30:

# echo set cl.column0.width 30 >> ~/.sngreprc
# echo set cl.column1.width 30 >> ~/.sngreprc

And it fits in 132 columns (without call state column), so I am considering reducing the SIP From and To columns to 30 so Call List panel can be properly displayed by default with that width. Less than that, user should configure what to see :)

@ssinyagin
Copy link
Author

ssinyagin commented Feb 7, 2015 via email

@Kaian
Copy link
Member

Kaian commented Feb 7, 2015

I also found a bug about that feature. If you set too many columns using a small screen width ... it crashes.

If you don't mind, I prefer handling each problem in different issues :D

I will merge fix_monochrome on monday

@Kaian Kaian added the bug label Feb 8, 2015
@Kaian Kaian added this to the v0.2.2 milestone Feb 9, 2015
@Kaian Kaian closed this as completed in 319b11b Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants