Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source option: allow pattern source outside of project tree. #11

Merged
merged 2 commits into from
Jul 31, 2015
Merged

source option: allow pattern source outside of project tree. #11

merged 2 commits into from
Jul 31, 2015

Conversation

Thell
Copy link
Contributor

@Thell Thell commented Jul 28, 2015

Fixes #10

@Thell
source option: allow pattern source outside of project tree.
95057c5 
Signed-off-by: Thell Fowler <thell@tbfowler.name>
@Thell
patterns: make the 6-other group accept color options.
418cb5e 
Signed-off-by: Thell Fowler <thell@tbfowler.name>
@Thell
Copy link
Contributor Author

Thell commented Jul 28, 2015

@iros The second commit on this should likely be in its own PR but I put it on my master, and when I do a GH PR they get bundled together.

Let me know if you want them to be distinct PRs.

@Thell Thell mentioned this pull request Jul 28, 2015
Closed
@iros iros merged commit 418cb5e into iros:master Jul 31, 2015
@iros
Copy link
Owner

iros commented Jul 31, 2015

Thanks for putting this together!
I merged this but with a few changes:

  • Those 6 were left with their colors fixed intentionally.
  • There was an issue with the path change that made the grunt tasks fail on their build. I pushed a fix to attend to that.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thell @iros