Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary tracebacks #177

Closed
troy2914 opened this issue Jan 25, 2019 · 2 comments
Closed

unnecessary tracebacks #177

troy2914 opened this issue Jan 25, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@troy2914
Copy link
Member

seen in 4.0.0-rc5
2019-01-25 00:17:14,666 irrd[30726]: [irrd.mirroring.mirror_runners_import#CRITICAL] An exception occurred while attempting a mirror update or initial import for APNIC: [Errno 104] Connection reset by peer
Traceback (most recent call last):
File "/home/irrd/irrd-venv/lib/python3.6/site-packages/irrd/mirroring/mirror_runners_import.py", line 44, in run
self.update_stream_runner.run(serial_newest_seen, database_handler=self.database_handler)
File "/home/irrd/irrd-venv/lib/python3.6/site-packages/irrd/mirroring/mirror_runners_import.py", line 207, in run
response = whois_query(nrtm_host, nrtm_port, query, end_markings)
File "/home/irrd/irrd-venv/lib/python3.6/site-packages/irrd/utils/whois_client.py", line 36, in whois_query
data = s.recv(1024*1024)
ConnectionResetError: [Errno 104] Connection reset by peer

the first part is all that is needed there:
2019-01-25 00:17:14,666 irrd[30726]: [irrd.mirroring.mirror_runners_import#CRITICAL] An exception occurred while attempting a mirror update or initial import for APNIC: [Errno 104] Connection reset by peer

@troy2914
Copy link
Member Author

Also the level of CRITICAL seems higher then needed. ALERT seems better.

@mxsasha
Copy link
Collaborator

mxsasha commented Jan 28, 2019

Yes, CRITICAL is too high. This is a catch for any unexpected exceptions in the mirroring process. I will add some more specific catches with errors we expect, that log less info, which will reduce the number of tracebacks.

We don't have ALERT - I think ERROR would be the most appropriate level. WARNING seems weak. CRITICAL should be reserved to "a data inconsistency may have occurred that may not fix itself".

@mxsasha mxsasha self-assigned this Jan 28, 2019
@mxsasha mxsasha added the enhancement New feature or request label Jan 28, 2019
@mxsasha mxsasha added this to To do in IRRDv4 phase 1 via automation Jan 29, 2019
@mxsasha mxsasha added this to the IRRD 4.0.0 milestone Jan 29, 2019
@mxsasha mxsasha closed this as completed in af2ad1d Feb 6, 2019
IRRDv4 phase 1 automation moved this from To do to Done Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants