Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geofeed: RPSL attribute (draft-ymbk-opsawg-finding-geofeeds) #396

Closed
job opened this issue Sep 11, 2020 · 4 comments · Fixed by #404
Closed

geofeed: RPSL attribute (draft-ymbk-opsawg-finding-geofeeds) #396

job opened this issue Sep 11, 2020 · 4 comments · Fixed by #404
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@job
Copy link
Member

job commented Sep 11, 2020

Is your feature request related to a problem? Please describe.

It seems https://tools.ietf.org/html/draft-ymbk-opsawg-finding-geofeeds-03 is overloading a remarks: field with an attribute which then points to a URL. We can easily improve on this as there is no clash with other attribute names.

Describe the solution you'd like

IRRdv4 should allow setting, mirroring and outputting a geofeed: attribute.

Only 1 geofeed: attribute is allowed per inetnum object. The attribute is not allowed in other RPSL object classes

Additional context

https://tools.ietf.org/html/draft-ymbk-opsawg-finding-geofeeds-03

example:

inetnum: 192.0.2.0 - 192.0.2.255  # example
geofeed: https://example.com/geofeed.csv
source: XXX
@randyqx
Copy link

randyqx commented Sep 11, 2020

this would be very cool.

btw, erik whacked me that s/inetnum/inetnum & inet6num/

@mxsasha
Copy link
Collaborator

mxsasha commented Sep 14, 2020

This seems reasonable. We can do basic URL validation for syntax too (for authoritative objects).

For mirroring this would actually already work: IRRd accepts unknown attributes from mirrors, like sponsoring-org in inet6num in RIPE.

@mxsasha mxsasha self-assigned this Sep 14, 2020
@mxsasha mxsasha added the enhancement New feature or request label Sep 14, 2020
@mxsasha mxsasha added this to To do in NTT Support Contract 2020 via automation Sep 14, 2020
@mxsasha mxsasha added this to the Release 4.2 milestone Sep 15, 2020
mxsasha added a commit that referenced this issue Oct 12, 2020
@mxsasha mxsasha linked a pull request Oct 12, 2020 that will close this issue
@mxsasha mxsasha moved this from To do to In progress in NTT Support Contract 2020 Oct 12, 2020
@mxsasha
Copy link
Collaborator

mxsasha commented Oct 12, 2020

@job To be clear: this is an optional attribute in both inetnum and inet6num, may only occur once, must be a valid HTTP/HTTPS URL? The draft doesn't specify beyond "URL", so it could be argued we should allow FTP too.

mxsasha added a commit that referenced this issue Oct 12, 2020
mxsasha added a commit that referenced this issue Oct 12, 2020
@job
Copy link
Member Author

job commented Oct 12, 2020

@job To be clear: this is an optional attribute in both inetnum and inet6num, may only occur once, must be a valid HTTP/HTTPS URL? The draft doesn't specify beyond "URL", so it could be argued we should allow FTP too.

Yes, this is an apt summary. HTTP and HTTPS scheme for now are probably fine

mxsasha added a commit that referenced this issue Oct 12, 2020
NTT Support Contract 2020 automation moved this from In progress to Done Oct 12, 2020
mxsasha added a commit that referenced this issue Oct 12, 2020
mxsasha added a commit that referenced this issue Oct 12, 2020
mxsasha added a commit that referenced this issue Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants