Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last-modified attribute should not be rejected on authoritative updates #587

Closed
mxsasha opened this issue Nov 16, 2021 · 2 comments · Fixed by #592
Closed

last-modified attribute should not be rejected on authoritative updates #587

mxsasha opened this issue Nov 16, 2021 · 2 comments · Fixed by #592
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mxsasha
Copy link
Collaborator

mxsasha commented Nov 16, 2021

IRRD automatically adds the last-modified attribute on authoritative objects since #290. However, when submitting changes to objects, IRRD rejects this attribute as it's unknown. This makes sense as it's not a "real" RPSL attribute, but IRRD should just replace the value. This is potentially very confusing for users.

For rpki-ov-state (#270) we probably already discard it silently, but should double check.

@mxsasha mxsasha added the enhancement New feature or request label Nov 16, 2021
@mxsasha mxsasha added this to the Release 4.3 milestone Nov 16, 2021
@mxsasha mxsasha self-assigned this Nov 16, 2021
@mxsasha mxsasha added this to To do in Community support via automation Nov 16, 2021
@mxsasha mxsasha modified the milestones: Release 4.3, Release 4.2.1 Nov 26, 2021
Community support automation moved this from To do to Done Nov 26, 2021
mxsasha added a commit that referenced this issue Dec 1, 2021
@rubenskuhl
Copy link

Thanks for that @mxsasha . Have you confirmed that rpki-ov-state is being silently discarded ?

@mxsasha
Copy link
Collaborator Author

mxsasha commented Feb 10, 2022

Thanks for that @mxsasha . Have you confirmed that rpki-ov-state is being silently discarded ?

Yes, set here for route for example, and there are also tests for this.

It's a bit different from last-modified, because rpki-ov-state is always relative to this specific IRRD instance, whereas last-modified is relative to the RPSL database/source. So for last-modified we accept and keep the value from a mirror, for rpki-ov-state we do not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants