Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

can't review large changes #755

Closed
aspiers opened this issue Sep 1, 2016 · 2 comments
Closed

can't review large changes #755

aspiers opened this issue Sep 1, 2016 · 2 comments
Labels
enhancement

Comments

@aspiers
Copy link
Collaborator

aspiers commented Sep 1, 2016

For example, https://github.com/crowbar/crowbar-openstack/pull/498/files currently shows:

2,106 additions, 1,907 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

Maybe this is done to avoid overloading the browser with a huge page, or maybe to avoid overloading the servers, but there should still be some way of reviewing large PRs online, e.g. via some pagination system or similar.
@aspiers aspiers mentioned this issue Sep 1, 2016
Merged
@TPS
Copy link
Collaborator

TPS commented Sep 25, 2016

#587?

@aspiers
Copy link
Collaborator Author

aspiers commented Sep 25, 2016

Yes, thanks - I missed that. Closing as a duplicate.

@aspiers aspiers closed this as completed Sep 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aspiers @TPS @cirosantilli