Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fails on windows #13

Open
BurtHarris opened this issue Jun 5, 2017 · 2 comments · May be fixed by #23
Open

test fails on windows #13

BurtHarris opened this issue Jun 5, 2017 · 2 comments · May be fixed by #23

Comments

@BurtHarris
Copy link

Microsoft Windows [Version 10.0.15063]
(c) 2017 Microsoft Corporation. All rights reserved.

C:\Users\Burt_>cd \code\isexe

C:\code\isexe>npm i
up to date in 1.345s

C:\code\isexe>npm test

> isexe@2.0.0 test C:\code\isexe
> tap test/*.js --100

module.js:487
    throw err;
    ^

Error: Cannot find module 'C:\Users\Burt_\.node-spawn-wrap-2296-ee88a1276edb\node.EXE'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:575:3
test/basic.js ......................................... 0/1
  not ok test/basic.js
    timeout: 240000
    file: test/basic.js
    command: 'C:\Program Files\nodejs\node.EXE'
    args:
      - test/basic.js
    cwd: 'C:\code\isexe'
    exitCode: 1

total ................................................. 0/1


  0 passing (131.621ms)
  1 failing

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|
@BurtHarris
Copy link
Author

And I thought fixing #12 was going to be easy...

BurtHarris pushed a commit to BurtHarris/isexe that referenced this issue Jun 5, 2017
Use fs.exists / existsSync to avoid exception on Windows

This is currently untested because the test suite was failing when I started, issue isaacs#13
@Gudahtt
Copy link

Gudahtt commented Aug 2, 2018

It looks like this failure was caused by tapjs/tapjs#373 which itself was caused by a bug in spawn-wrap. Updating to a newer version of tap should fix the issue.

It looks any version of tap > v10.7.1 should guarantee that the version of spawn-wrap used includes this particular bug fix. We'd might as well update to v12 though I suppose.

Gudahtt added a commit to Gudahtt/isexe that referenced this issue Aug 2, 2018
A dependency of `tap` (`spawn-env`, via nyc) was causing tests to fail.
Any version of `tap` >= v10.7.1 will guarantee a version of `spawn-env`
with that bug fix. The minimum has been increased to v12.0.1 because the
breaking changes between v10 and v12 do not affect this package.

Closes isaacs#13
@Gudahtt Gudahtt linked a pull request Aug 2, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants