Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawn-wrap test on windows & Appveyor failing #55

Closed
BurtHarris opened this issue Jun 5, 2017 · 6 comments
Closed

spawn-wrap test on windows & Appveyor failing #55

BurtHarris opened this issue Jun 5, 2017 · 6 comments

Comments

@BurtHarris
Copy link

Latest appveyor results show this failing on Windows https://ci.appveyor.com/project/isaacs/spawn-wrap

I'm guessing that may be a contributing factor to isaacs/isexe#13

@BurtHarris BurtHarris changed the title Test on windows & Appveyor failing spawn-wrap test on windows & Appveyor failing Jun 5, 2017
@mykmelez
Copy link

I'm guessing that may be a contributing factor to isaacs/isexe#13

This one looks like #56, which I've fixed in #57. It's possible that PR also fixes the test failures on Appveyor, although I'm still seeing test failures locally on Windows.

@mykmelez
Copy link

mykmelez commented Jul 3, 2017

I've now fixed these failures in #57.

@BurtHarris
Copy link
Author

It looks like the latest Appveyor failure is only on NodeJS v 0.12, and that an incompatibility between that version and NPM 5.0.4 may be to blame.

Perhaps it's time to drop support for NodeJS 0.12.

@mykmelez
Copy link

@isaacs fixed this in 393f800 and 2921d64.

@demurgos
Copy link
Contributor

This issue can be closed, Windows tests are working right now. (#82).

/cc @coreyfarrell

@coreyfarrell
Copy link
Member

Thanks for the ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants