Fix copyFile wrapper when retry() hits EMFILE again #209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
copyFile
wrapper introduced in #199 does not follow the same pattern as the other wrappers, and enqueued the wrappedcopyFile
rather than the wrapper function, which means that a subsequentEMFILE
orENFILE
error occurring when retrying thecopyFile
would fail and bubble theEMFILE
orENFILE
to the calling code rather than enqueue again. This fix applies the same pattern by introducinggo$copyFile
and enqueueing it rather thanfs$copyFile
.Fixes #208.
All tests pass and coverage goes up a bit (probably just because the new lines of test code are covered). I couldn't find tests that validate the
EMFILE
retry logic for thefs
function wrappers (at least not forcopyFile
).