add missing fs.readdir encoding option #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs.readdir has optional option called encoding: https://nodejs.org/api/fs.html#fs_fs_readdir_path_options_callback
|
Fails tests. I thikn it's supposed to accept an object with an 'encoding' property, not an encoding string. |
missing encoding argument for readdir function
digital-flowers
commented
Sep 27, 2016
|
readdir accept object or string but the issue in the previous patch was because of a missing argument, sorry it was an undo before commit by mistake |
isaacs
added a commit
that referenced
this pull request
Sep 27, 2016
|
Adding the param arbitrarily breaks older versions that did not take this parameter. Different approach in #93 that is agnostic about the existence of the parameter and its type. Can you check to see if that meets your needs? |
|
ok i understand btw thanks for this module :) |
|
i think you can close this request |
isaacs
added a commit
that referenced
this pull request
Sep 28, 2016
iarna
added a commit
to npm/npm
that referenced
this pull request
Oct 7, 2016
Make `fs.Stats` `.uid` and `.gid` fields always be unsigned. Pass through optional arguments to `fs.readdir`. Previously they were dropped. Fixes: #13918 Fixes: isaacs/node-graceful-fs#84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.readdir has optional option called encoding:
https://nodejs.org/api/fs.html#fs_fs_readdir_path_options_callback