This repository has been archived by the owner on Feb 27, 2022. It is now read-only.
use a regex to find the first non-host character #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into how your url package parsed URLs, and I thought I'd suggest a more compact way to find the index of the first non-host character.
While not super-important, here's a jsperf of the two methods: http://jsperf.com/loop-vs-regex-for-node-url-parse