better handling of closing script tags #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts can contain tag characters within their bounds (string, templates, etc). These characters should not cause the script tag to appear closed. Wait for an actual script tag closure. Note that the presence of the full string "</script>" within the tag will still cause termination as no checking for quotes or other specifics is done. This just expands the termination check slightly.
|
@isaacs any thoughts on this? |
|
comments? or is this fix not desirable? |
|
Landed on 367c594. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts can contain tag characters within their bounds (string,
templates, etc). These characters should not cause the script tag to
appear closed. Wait for an actual script tag closure.
Note that the presence of the full string "</script>" within the tag
will still cause termination as no checking for quotes or other
specifics is done. This just expands the termination check slightly.