Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math plugin could support CKEditor 5 DLL build #46

Closed
isaul32 opened this issue May 18, 2021 · 2 comments · Fixed by #83
Closed

Math plugin could support CKEditor 5 DLL build #46

isaul32 opened this issue May 18, 2021 · 2 comments · Fixed by #83
Labels
enhancement New feature or request

Comments

@isaul32
Copy link
Owner

isaul32 commented May 18, 2021

Currently math plugin must be added in CKEditor 5 build at compilation time. With new DLL build API it could be possible add math plugin afterwards.

Some documentation about DDL builds:
@isaul32 isaul32 added the enhancement New feature or request label May 18, 2021
@tony
Copy link
Collaborator

tony commented Feb 8, 2022

@isaul32 This makes sense to me

Additionally, #56 may be of assistance with this.

DanielKulbe added a commit to DanielKulbe/ckeditor5-math that referenced this issue Feb 6, 2023
@DanielKulbe
isaul32#46 Convert to DLL compatible plugin
a435ce3
@DanielKulbe DanielKulbe mentioned this issue Feb 6, 2023
Merged
@DanielKulbe
Copy link
Contributor

Created a pull request with my suggestion. Two things to point out:

  1. The AutoformatMath plugin should get rid of the blockAutoformatEditing() from Autoformat plugin to have a really clean plugin build
  2. Some tests still fails - mainly related to MathUI and and AutoMath ... that is not my field of expertise, and also maybe also not the correct place to takle those issues

DanielKulbe added a commit to DanielKulbe/ckeditor5-math that referenced this issue Feb 7, 2023
@DanielKulbe
Convert to DLL compatible plugin (isaul32#46)
457ee76
DanielKulbe added a commit to DanielKulbe/ckeditor5-math that referenced this issue Feb 7, 2023
@DanielKulbe
Convert to DLL compatible plugin (isaul32#46)
191e33e
DanielKulbe added a commit to DanielKulbe/ckeditor5-math that referenced this issue Feb 21, 2023
@DanielKulbe
Convert to DLL compatible plugin (isaul32#46)
b2ed752
@tony tony closed this as completed in #83 Mar 14, 2023
tony pushed a commit that referenced this issue Mar 14, 2023
@DanielKulbe @tony
Convert to DLL compatible plugin (#46)
3833617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#46 Convert to DLL compatible plugin DanielKulbe/ckeditor5-math
3 participants
@tony @DanielKulbe @isaul32