Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"hiding" doesn't work on place types #186

Closed
paregorios opened this issue Jul 12, 2016 · 5 comments
Closed

"hiding" doesn't work on place types #186

paregorios opened this issue Jul 12, 2016 · 5 comments

Comments

@paregorios
Copy link
Member

paregorios commented Jul 12, 2016

The new @@pleiades-settings backend for the place types vocabulary includes the "hidden" option, but when selected, the corresponding term still shows up in the pick list on place and location edit views. Consider the following example, taken live from production.

in @@pleiades-settings

screen shot 2016-07-12 at 9 44 47 am

in pick list for http://pleiades.stoa.org/places/529754544

screen shot 2016-07-12 at 9 43 15 am

@davisagli
Copy link

I completely forgot that for time periods this is enforced in a customized widget, and we need a similar customization to the widget for place types.

@witekdev
Copy link
Contributor

I guess this will also need to be updated for the relationship types and the upcoming location types vocab widgets as they too include the "hidden" field?

@davisagli
Copy link

@witekdev We said this morning that we don't need the 'hidden' flag for the location types vocab. But you're right, since we're making it available for relationship types we should probably make it work.

@witekdev
Copy link
Contributor

@davisagli I guess I must have missed that detail. Tnx!

@davisagli
Copy link

This is fixed (in production).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants