Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

who is "admin2" and why are they showing up on the "credits" page? #266

Closed
paregorios opened this issue Dec 13, 2016 · 5 comments
Closed

Comments

@paregorios
Copy link
Member

https://pleiades.stoa.org/credits

No name line, but that's the user account shown in the links.

Note, moreover, that creator link doesn't return results.\

screen shot 2016-12-13 at 8 18 25 am

@davisagli
Copy link

This is a Zope-level admin account that I was using. I didn't intend to edit any content with it but I must have at some point. Looking at the catalog the items that were created by this user are:

@paregorios
Copy link
Member Author

@davisagli : removing admin2 from the "creators" list on https://pleiades.stoa.org/credits by itself didn't work, but once I'd changed the owner for the credits page, then that got rid of the "one addition" aspect. But the https://pleiades.stoa.org/help/help-and-information page was edited by someone using admin2 back in May and I don't see how to expunge that contribution without punting subsequent changes that I've made, and I can't see another way to remove admin2 from the mix.

I do think that we are suppressing (or at least used to) in the view template for Credits the plain old "admin" user (and also thomase and sgillies). Where would I look for that code to see if I can intervene further regarding admin2?

@paregorios
Copy link
Member Author

paregorios commented Dec 14, 2016

I found pleiades-notredame, but cannot see any filtering. Whatever we once had in place to keep sgillies out of the listing is now gone, but thomase is still not there, nor "admin". But I cannot detect whatever code it is that makes that happen. Perhaps it is hidden somewhere else ...

@davisagli
Copy link

@paregorios I think you can just edit https://pleiades.stoa.org/help/help-and-information, and delete admin2 from the Contributors field on the Creators tab. Or is the issue that you also don't want admin2 to show up in the revision history?

The list shown in the credits template is now generated by code in credits.py in PleiadesEntity. I think the list you mentioned is here: https://github.com/isawnyu/PleiadesEntity/blob/master/Products/PleiadesEntity/browser/credits.py#L7

@paregorios
Copy link
Member Author

this was resolved long ago. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants