Unit test for parameter interpolation failure #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 78.58% 78.75% +0.16%
==========================================
Files 24 24
Lines 2358 2358
==========================================
+ Hits 1853 1857 +4
+ Misses 505 501 -4
Continue to review full report at Codecov.
|
berquist
requested changes
Dec 11, 2019
vistautils/parameters.py
Outdated
| @@ -1216,7 +1216,7 @@ def _check_all_keys_strings(mapping: Mapping, path=None): | |||
| if isinstance(val, Mapping): | |||
| YAMLParametersLoader._check_all_keys_strings(val) | |||
|
|
|||
| _INTERPOLATION_REGEX = re.compile(r"%([\w\.]+)%") | |||
| _INTERPOLATION_REGEX = re.compile(r"%([\w.\-_]+)%") | |||
There was a problem hiding this comment.
If I check out this PR but then revert the regex change, this still passes. Underscore should be covered by \w, so that leaves \w\. versus \w.\-. Here are my tests:
In [17]: test_str = "foo-bar_baz.meep"
In [18]: re.findall(r"[\w\.]+", test_str)
Out[18]: ['foo', 'bar_baz.meep']
In [19]: re.findall(r"[\w.\-]+", test_str)
Out[19]: ['foo-bar_baz.meep']
In [20]: re.findall(r"[\w\-]+", test_str)
Out[20]: ['foo-bar_baz', 'meep']We should have a test for this if we don't already.
berquist
approved these changes
Dec 11, 2019
|
I've confirmed that this effectively tests the current regex and breaks when reverting to the old one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.