Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_root_dir_name to io_utils #140

Closed
wants to merge 1 commit into from
Closed

Conversation

mspector
Copy link
Collaborator

In trying to port some closed source code from aida-tools to an open source repo, I discovered this function, with the comment "move to vistautils?"

This PR answers that question with a "yes"

https://github.com/isi-vista/aida-tools/blob/master/aida_tools/utils.py#L75

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #140 into master will increase coverage by 2.38%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   84.20%   86.59%   +2.38%     
==========================================
  Files          25       25              
  Lines        2558     3498     +940     
==========================================
+ Hits         2154     3029     +875     
- Misses        404      469      +65     
Impacted Files Coverage Δ
vistautils/io_utils.py 88.31% <7.69%> (-3.56%) ⬇️
vistautils/attrutils.py 0.00% <0.00%> (ø)
vistautils/scripts/directory_to_key_value_store.py 97.14% <0.00%> (+0.71%) ⬆️
vistautils/parameters.py 86.38% <0.00%> (+0.89%) ⬆️
vistautils/range.py 94.63% <0.00%> (+1.13%) ⬆️
vistautils/span.py 91.39% <0.00%> (+5.11%) ⬆️
vistautils/key_value.py 92.27% <0.00%> (+9.39%) ⬆️
vistautils/scripts/split_key_value_store.py 86.84% <0.00%> (+22.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a253d9c...81a33b3. Read the comment docs.

@mspector
Copy link
Collaborator Author

No need to review this yet until I resolve code coverage issues

@mspector mspector closed this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant