Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching the unused result => tests fail #1

Open
WildCryptoFox opened this issue Jul 15, 2020 · 0 comments
Open

Patching the unused result => tests fail #1

WildCryptoFox opened this issue Jul 15, 2020 · 0 comments

Comments

@WildCryptoFox
Copy link

WildCryptoFox commented Jul 15, 2020

verifier.verify_compact(&self.proof).or_else(|_| return Err(CredentialError::VerificationFailure));

Patching this code to

verifier.verify_compact(&self.proof)?;

results in failed tests

running 12 tests
test encoding::test::encoding_decoding_roundtrip ... ok
test amacs::test::secret_key_generate ... ok
test amacs::test::amac_verification ... ok
test nizk::test::encryption_proof ... ok
test nizk::test::credential_proof_1_attribute ... FAILED
test parameters::test::hash_and_pray ... ok
test parameters::test::issuer_parameters_generate ... ok
test parameters::test::system_parameters_serialize_deserialize ... ok
test symmetric::test::encrypt_decrypt_roundtrip ... ok
test nizk::test::issuance_proof ... ok
test nizk::test::issuance_proof_identity_plaintext ... ok
test nizk::test::credential_proof_8_attributes ... FAILED

failures:

---- nizk::test::credential_proof_1_attribute stdout ----
thread 'nizk::test::credential_proof_1_attribute' panicked at 'assertion failed: verification.is_ok()', src/nizk.rs:930:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- nizk::test::credential_proof_8_attributes stdout ----
thread 'nizk::test::credential_proof_8_attributes' panicked at 'assertion failed: verification.is_ok()', src/nizk.rs:908:9


failures:
    nizk::test::credential_proof_1_attribute
    nizk::test::credential_proof_8_attributes

test result: FAILED. 10 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant