Quick refactor, bug fixes and breaking changes. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WildCryptoFox
commented
Jul 15, 2020
Comment on lines
34
to
43
| pub(crate) fn sizeof_system_parameters(number_of_attributes: u8) -> usize { | ||
| // G_y is always at least three elements | ||
| if number_of_attributes < 3 { | ||
| return 32 * (5 + 3 + number_of_attributes as usize + 4) + 1 | ||
| // 32 * (5 + 3 + number_of_attributes as usize + 4) + 1 | ||
| 385 + 32 * number_of_attributes as usize | ||
| } else { | ||
| // 32 * (5 + (2 * number_of_attributes as usize) + 4) + 1 | ||
| 289 + 64 * number_of_attributes as usize | ||
| } | ||
| 32 * (5 + (2 * number_of_attributes as usize) + 4) + 1 | ||
| } |
There was a problem hiding this comment.
Which part of the paper elaborates on the minimum of 3 attributes to use group elements? Why do the sizes differ more than just 289 + 64 * core::cmp::max(3, number_of_attributes as usize)?
WildCryptoFox
commented
Jul 15, 2020
Comment on lines
+86
to
+87
| #[cfg(all(debug_assertions, feature = "std", feature = "debug-errors"))] | ||
| eprintln!("Could not decode {:?} from bytes: {:?}", $name, bytes); |
There was a problem hiding this comment.
I didn't add the debug-errors feature to Cargo.toml but I'm not sure this code belongs here.
WildCryptoFox
commented
Jul 15, 2020
Comment on lines
+103
to
+107
| let G = try_deserialize!("G", &chunks.next().unwrap()); | ||
| let G_w = try_deserialize!("G_w", &chunks.next().unwrap()); | ||
| let G_w_prime = try_deserialize!("G_w_prime", &chunks.next().unwrap()); | ||
| let G_x_0 = try_deserialize!("G_x_0", &chunks.next().unwrap()); | ||
| let G_x_1 = try_deserialize!("G_x_1", &chunks.next().unwrap()); |
There was a problem hiding this comment.
These unwraps won't panic as you've already checked the length is within range.
WildCryptoFox
commented
Jul 15, 2020
Comment on lines
113
to
119
| fn from(source: &[u8; 30]) -> Plaintext { | ||
| let (M1, _) = encode_to_group(source); | ||
| let M2: RistrettoPoint = RistrettoPoint::hash_from_bytes::<Sha512>(source); | ||
| let m3: Scalar = Scalar::hash_from_bytes::<Sha512>(source); | ||
| let h = Sha512::default().chain(&source); | ||
| let M2: RistrettoPoint = RistrettoPoint::from_hash(h.clone().chain(b"M2")); | ||
| let m3: Scalar = Scalar::from_hash(h.chain(b"m3")); | ||
|
|
||
| Plaintext { M1, M2, m3 } |
There was a problem hiding this comment.
Breaking change. The old hash functions reused keying material while the new functions are independent.
WildCryptoFox
commented
Jul 15, 2020
Comment on lines
+162
to
+165
| let h = Sha512::default().chain(&master_secret[..]); | ||
| let a: Scalar = Scalar::from_hash(h.clone().chain(b"a.")); | ||
| let a0: Scalar = Scalar::from_hash(h.clone().chain(b"a0")); | ||
| let a1: Scalar = Scalar::from_hash(h.chain(b"a1")); |
There was a problem hiding this comment.
Breaking change. The old hash functions used a hash-chain to derive the scalars. The new functions are independent.
WildCryptoFox
commented
Jul 15, 2020
| @@ -789,7 +789,7 @@ impl ProofOfValidCredential { | |||
| } | |||
| } | |||
|
|
|||
| verifier.verify_compact(&self.proof).or_else(|_| return Err(CredentialError::VerificationFailure)); | |||
| verifier.verify_compact(&self.proof)?; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.