Feature/compressed try from #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces copy-pasta in downstream users to check the length of the slice beforehand.
isislovecruft
requested changes
Oct 28, 2019
src/scalar.rs
Outdated
Comment on lines
481
to
487
| impl From<[u8; 32]> for Scalar { | ||
| fn from(bytes: [u8; 32]) -> Self { | ||
| Scalar{ bytes } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This would allow users to construct noncanonical Scalars, both in that the most significant bit could be set, which is explicitly disallowed, and in that they could be unreduced modulo the basepoint order.
src/scalar.rs
Outdated
| let mut s_bytes = [0x00u8; 32]; | ||
| s_bytes.copy_from_slice(bytes); | ||
|
|
||
| Ok(Scalar::from_bits(s_bytes)) |
There was a problem hiding this comment.
I feel very nervous calling from_bits() under the hood here, it should only be called when explicitly needed, for protocols that rely on it such as x25519 diffie-hellman, because it allows unreduced Scalars to be constructed.
isislovecruft
force-pushed
the
feature/compressed-try-from
branch
from
a7f2c6c
to
9ae2e3b
Compare
…t, CompressedEdwardsY and Scalar
vlopes11
force-pushed
the
feature/compressed-try-from
branch
from
452b935
to
ccb97b6
Compare
|
Kind of targeting for different purposes, since there was the change from the default lib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryFrom<&[u8]>to ScalarFrom<[u8; 32]>to types that reflects this structure