Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

Commit

Permalink
scsi: qla2xxx: Fix hang in fcport delete path
Browse files Browse the repository at this point in the history
[ Upstream commit f00b3428a801758243693e046b34226e92bc56b3 ]

A hang was observed in the fcport delete path when the device was
responding slow and an issue-lip path (results in session termination) was
taken.

Fix this by issuing logo requests unconditionally.

PID: 19491  TASK: ffff8e23e67bb150  CPU: 0   COMMAND: "kworker/0:0"
 #0 [ffff8e2370297bf8] __schedule at ffffffffb4f7dbb0
 150balbes#1 [ffff8e2370297c88] schedule at ffffffffb4f7e199
 150balbes#2 [ffff8e2370297c98] schedule_timeout at ffffffffb4f7ba68
 150balbes#3 [ffff8e2370297d40] msleep at ffffffffb48ad9ff
 150balbes#4 [ffff8e2370297d58] qlt_free_session_done at ffffffffc0c32052 [qla2xxx]
 150balbes#5 [ffff8e2370297e20] process_one_work at ffffffffb48bcfdf
 150balbes#6 [ffff8e2370297e68] worker_thread at ffffffffb48bdca6
 150balbes#7 [ffff8e2370297ec8] kthread at ffffffffb48c4f81

Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Quinn Tran authored and isjerryxiao committed Dec 17, 2019
1 parent 6ea0444 commit 7ebde97
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/scsi/qla2xxx/qla_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,6 @@ qla2x00_async_logout(struct scsi_qla_host *vha, fc_port_t *fcport)
struct srb_iocb *lio;
int rval = QLA_FUNCTION_FAILED;

if (!vha->flags.online || (fcport->flags & FCF_ASYNC_SENT))
return rval;

fcport->flags |= FCF_ASYNC_SENT;
sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);
if (!sp)
Expand Down

0 comments on commit 7ebde97

Please sign in to comment.