Travis ci #33
Merged
Travis ci #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current CI shows some issue about installing glfw3 and linking png header files. |
Closed
syncle
commented
Jun 1, 2017
| @@ -14,7 +14,7 @@ The compilation has been tested on Ubuntu 16.04 (gcc 5.4) and Ubuntu 15.10 (gcc | |||
| > scripts/install-deps-ubuntu.sh | |||
| > mkdir build | |||
| > cd build | |||
| > cmake ../source/ | |||
| > cmake ../src/ | |||
| > make | |||
There was a problem hiding this comment.
This is not consistent with the current folder tree, so we need to fix it.
syncle
commented
Jun 1, 2017
| set(Open3D_BUILD_PYTHON_BINDING OFF) | ||
| set(Open3D_BUILD_PYTHON_BINDING_TESTS OFF) | ||
| endif (NOT PythonLibs_FOUND) | ||
|
|
There was a problem hiding this comment.
Python binding is only built when Python is installed in the system.
syncle
commented
Jun 1, 2017
| add_subdirectory(zlib) | ||
| add_subdirectory(libpng) | ||
| endif (PNG_FOUND) | ||
|
|
There was a problem hiding this comment.
Using pkg_search_module instead of buggy find_package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic compilation settings for Ubuntu trusty machine.