Build with libomp 11.1 and package it in the macOS wheel #5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
ssheorey
force-pushed
the
ss/gh-macos-omp
branch
from
1d6feb8
to
d9e77f2
Compare
Fail build if newer libomp found
ssheorey
force-pushed
the
ss/gh-macos-omp
branch
from
d9e77f2
to
0864a87
Compare
errissa
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yxlao)
Directly installing the Ruby formula will install for the current OS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package libomp v11.1.0, if it is not installed. Later version cause crash on x86_64 if PyTorch is already imported.
microsoft/LightGBM#4229
This change is