-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to fmt-v10 #6783
add support to fmt-v10 #6783
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Hi @daizhirui can you check the Windows errors? |
@ssheorey I fix several issues and test it with my Windows laptop which uses
|
There are still errors with MSVC 14.29.30154.0, which is not tested on my windows laptop. I also notice there are warnings like
which does not appear when I test the build with MSVC 14.39.33519 provided by Visual Studio 2022. I will try to fix the build with Visual Studio 2019. However, is there a plan to update the test environment? Since some compile options configured by CMake are not supported by Visual Studio 2019, I think it is time to upgrade the test environmenet. |
It is the issue of the combination of |
Thanks for fixing these. We will update MSVC pretty soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daizhirui Looks good!
Type
Motivation and Context
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Make the build work with fmt-10.2.0 such that "USE_SYSTEM_FMT" works again.