Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to fmt-v10 #6783

Merged
merged 13 commits into from
Jun 14, 2024
Merged

add support to fmt-v10 #6783

merged 13 commits into from
Jun 14, 2024

Conversation

daizhirui
Copy link
Contributor

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Make the build work with fmt-10.2.0 such that "USE_SYSTEM_FMT" works again.

Copy link

update-docs bot commented May 3, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey self-requested a review May 5, 2024 06:26
@ssheorey
Copy link
Member

Hi @daizhirui can you check the Windows errors?

@daizhirui
Copy link
Contributor Author

@ssheorey I fix several issues and test it with my Windows laptop which uses CUDA 11.8:

  1. v10.2.1 is not compatible with CUDA on Windows: use v10.1.1 instead when BUILD_CUDA_MODULE is ON on Windows.
  2. add a missing formatter for cusolverStatus_t.

@daizhirui
Copy link
Contributor Author

daizhirui commented May 21, 2024

There are still errors with MSVC 14.29.30154.0, which is not tested on my windows laptop. I also notice there are warnings like

MASM : warning A4018: invalid command-line option : /GS- [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\daizh 
\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zc:wchar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\User 
s\daizh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Z:wchar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users 
\daizh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zwchar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\ 
daizh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zchar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\d 
aizh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zhar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\da 
izh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\dai 
zh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zr_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\daiz 
h\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]

which does not appear when I test the build with MSVC 14.39.33519 provided by Visual Studio 2022.

I will try to fix the build with Visual Studio 2019. However, is there a plan to update the test environment? Since some compile options configured by CMake are not supported by Visual Studio 2019, I think it is time to upgrade the test environmenet.

@daizhirui
Copy link
Contributor Author

It is the issue of the combination of NVCC and MSVC v142. I fix it by switching fmt to 6.0.0 when MSVC v142 is used and BUILD_CUDA_MODULE is ON.

@ssheorey
Copy link
Member

ssheorey commented Jun 7, 2024

There are still errors with MSVC 14.29.30154.0, which is not tested on my windows laptop. I also notice there are warnings like

MASM : warning A4018: invalid command-line option : /GS- [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\daizh 
\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zc:wchar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\User 
s\daizh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Z:wchar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users 
\daizh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zwchar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\ 
daizh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zchar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\d 
aizh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zhar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\da 
izh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zar_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\dai 
zh\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]
MASM : warning A4018: invalid command-line option : /Zr_t [C:\Users\daizh\repos\Open3D\build_on_off_on_release\tbb\src\ext_tbb-build\tbb_static.vcxproj] [C:\Users\daiz 
h\repos\Open3D\build_on_off_on_release\ext_tbb.vcxproj]

which does not appear when I test the build with MSVC 14.39.33519 provided by Visual Studio 2022.

I will try to fix the build with Visual Studio 2019. However, is there a plan to update the test environment? Since some compile options configured by CMake are not supported by Visual Studio 2019, I think it is time to upgrade the test environmenet.

Thanks for fixing these. We will update MSVC pretty soon.

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daizhirui Looks good!

@ssheorey ssheorey merged commit 0bdedd3 into isl-org:main Jun 14, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants