fix(services-auth-ids-api): Revert removing of raw: true for clients #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #10449 +/- ##
=======================================
Coverage 39.69% 39.69%
=======================================
Files 4716 4716
Lines 85588 85589 +1
Branches 21447 21447
=======================================
+ Hits 33977 33978 +1
Misses 51611 51611
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eirikurn
approved these changes
Mar 11, 2023
saevarma
added a commit
that referenced
this pull request
Mar 13, 2023
…10449) * Use sequelize include to load associations. * Revert removing raw for clients.
6 tasks
saevarma
added a commit
that referenced
this pull request
Mar 13, 2023
…10449) * Use sequelize include to load associations. * Revert removing raw for clients.
kodiakhq bot
added a commit
that referenced
this pull request
Mar 13, 2023
…min api. (#10455) * fix(auth-admin-api): Use nestjs global prefix instead of ingress rewrite. (#10415) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(auth-admin-web): Fixes in auth-api-lib for auth-admin-web (#10448) * Fix auth-api-lib resource auth-admin-web. * Remove temporary code --------- Co-authored-by: Eiríkur Heiðar Nilsson <eirikur@nilsson.is> * fix(services-auth-ids-api): Revert removing of raw: true for clients (#10449) * Use sequelize include to load associations. * Revert removing raw for clients. * fix(auth-admin-web): Fix get for api resources in auth admin api. (#10457) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Eiríkur Heiðar Nilsson <eirikur@nilsson.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reverting removal of
raw: truefor clients.Why
To fix regression in IDS.
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist: