Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codeowners error #1081

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Fix codeowners error #1081

merged 4 commits into from
Sep 28, 2020

Conversation

eirikurn
Copy link
Member

What

Fix codeowners error. Org name had a typo, which stops all rules from working.

Why

To make sure code ownership is applied in pull requests.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against master before asking for a review

@eirikurn eirikurn requested review from a team and sindrig and removed request for a team September 27, 2020 17:30
sindrig
sindrig approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@sindrig sindrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we/should we create a lint step for this? E.g. something to prevent me to put in the wrong organization or team name?

@eirikurn
Copy link
Member Author

That would be ideal since this is surprisingly flaky. Don’t know if they’ve open sourced their parser/validator though.

@eirikurn eirikurn added the automerge Merge this PR as soon as all checks pass label Sep 28, 2020
@sindrig
Copy link
Contributor

sindrig commented Sep 28, 2020

That would be ideal since this is surprisingly flaky. Don’t know if they’ve open sourced their parser/validator though.

I'll do a quick investigation

@kodiakhq kodiakhq bot merged commit 48a2923 into master Sep 28, 2020
@kodiakhq kodiakhq bot deleted the fix-codeowners branch September 28, 2020 10:00
@sindrig sindrig mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindrig sindrig sindrig approved these changes

@darrikonn darrikonn darrikonn approved these changes

Assignees
No one assigned
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eirikurn @sindrig @darrikonn