Refactoring CI pipeline in preparation for documenting it #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindrig
reviewed
Oct 1, 2020
.github/workflows/build.yml
Outdated
| @@ -111,7 +89,7 @@ jobs: | |||
| else | |||
| export PUBLISH=true | |||
| fi | |||
| echo "::set-env name=PUBLISH::${PUBLISH}" | |||
| export PUBLISH=true | |||
There was a problem hiding this comment.
i know this is WIP but still
| @@ -134,10 +112,6 @@ jobs: | |||
| path: node_modules | |||
| key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}-yarn | |||
|
|
|||
| - name: Building NodeJS dependencies - host OS | |||
There was a problem hiding this comment.
actually we put both dependence updates in the same script
.github/workflows/build.yml
Outdated
| @@ -154,61 +128,45 @@ jobs: | |||
| run: echo "::set-env name=BRANCH::${GIT_BRANCH}" | |||
|
|
|||
| - name: Security audit Node modules | |||
| run: yarn run security-audit | |||
| run: ./scripts/security-audit.sh | |||
There was a problem hiding this comment.
why create scripts for one liners?
There was a problem hiding this comment.
Longer discussion, let's have it "live" ;)
scripts/license-audit.sh
Outdated
|
|
||
| source $DIR/_common.sh | ||
|
|
||
| cd $PROJECT_ROOT |
There was a problem hiding this comment.
suggest doing this in subshell
scripts/prepare_deps.sh
Outdated
| @@ -7,6 +7,10 @@ source $DIR/_common.sh | |||
|
|
|||
| # Build the node_modules as well as the base image for the final outputs and store it in the shared cache so it can be reused later | |||
|
|
|||
| cd $PROJECT_ROOT | |||
pshomov
changed the title
sindrig
approved these changes
Oct 2, 2020
| @@ -148,67 +123,51 @@ jobs: | |||
|
|
|||
| - name: Building NodeJS dependencies | |||
| if: steps.cache-deps.outputs.cache-hit != 'true' | |||
There was a problem hiding this comment.
Only thing I can see is that we might want to check the cache-hit status of steps.node-modules.outputs.cache-hit as well - I know it depends on the same file but if one was invalidated somehow or something... /shrug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #389
What
Pull parts of the GHA in scripts that can be run locally
Why
See https://github.com/island-is/handbook/blob/master/docs/adr/0002-continuous-integration.md#decision-drivers-policy
Checklist: