Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: nx-cloud feature toggle #11900

Closed
wants to merge 144 commits into from
Closed

ci: nx-cloud feature toggle #11900

wants to merge 144 commits into from

Conversation

busla
Copy link
Member

@busla busla commented Aug 21, 2023

Use NX cloud

First attempt at using NX cloud. By adding nx-cloud label to the PR an nx-cloud adapted workflow will be run

NOTE: THIS IS STILL WIP BUT NEEDED TO BE SET AS READY SO ALL JOBS ARE RUN.

What

NX cloud should speed up our tasks both in CI and on local developer environments. This PR is the first iteration of many while we fine tune the NX input parameters.

get-secrets

Refactored get-secrets bash script to our infra cli and improved how secrets are updated. Out of sync lines in .env.secret and ssm param store will be updated, new ones added and a diff report is added to .env.log.

Alternative .env files can also be added and mapped to ssm param names and can be flagged as a bash script with exported envs or a standard .env file to support nx-cloud.env.

To work with NX cloud locally we need the NX_CLOUD_ACCESS_TOKEN and NX loads the token automatically from nx-cloud.env.

@busla busla requested review from a team as code owners August 21, 2023 22:35
@busla busla requested a review from eirikurn August 21, 2023 22:35
@busla busla added the nx-cloud label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #11900 (da24663) into main (e565fb5) will decrease coverage by 0.01%.
Report is 888 commits behind head on main.
The diff coverage is n/a.

❗ Current head da24663 differs from pull request most recent head 9c51c1d. Consider uploading reports for the commit 9c51c1d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11900      +/-   ##
==========================================
- Coverage   38.02%   38.01%   -0.01%     
==========================================
  Files        5301     5165     -136     
  Lines      102857    97926    -4931     
  Branches    28880    24988    -3892     
==========================================
- Hits        39111    37227    -1884     
+ Misses      63746    60699    -3047     
Flag Coverage Δ
air-discount-scheme-backend 56.72% <ø> (-0.28%) ⬇️
air-discount-scheme-web 0.00% <ø> (ø)
api 4.07% <ø> (+0.17%) ⬆️
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 34.95% <ø> (-0.08%) ⬇️
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 54.59% <ø> (-2.31%) ⬇️
api-domains-communications 40.81% <ø> (-0.01%) ⬇️
api-domains-criminal-record 43.56% <ø> (+0.31%) ⬆️
api-domains-driving-license 45.21% <ø> (+0.11%) ⬆️
api-domains-education 21.01% <ø> (-8.04%) ⬇️
api-domains-health-insurance 27.07% <ø> (-0.14%) ⬇️
api-domains-license-service 20.45% <ø> (-1.40%) ⬇️
api-domains-mortgage-certificate 34.09% <ø> (+0.05%) ⬆️
api-domains-payment-schedule 39.32% <ø> (+0.03%) ⬆️
application-api-files 52.34% <ø> (-0.19%) ⬇️
application-core 72.77% <ø> (+0.03%) ⬆️
application-system-api 42.79% <ø> (-0.43%) ⬇️
application-template-api-modules 25.14% <ø> (+0.13%) ⬆️
application-templates-accident-notification 19.76% <ø> (-0.27%) ⬇️
application-templates-criminal-record 17.90% <ø> (-4.29%) ⬇️
application-templates-driving-license 14.91% <ø> (-1.90%) ⬇️
application-templates-example-payment 19.55% <ø> (-1.83%) ⬇️
application-templates-financial-aid 12.15% <ø> (-0.16%) ⬇️
application-templates-general-petition 18.78% <ø> (-0.96%) ⬇️
application-templates-health-insurance 23.70% <ø> (-0.25%) ⬇️
application-templates-mortgage-certificate 36.37% <ø> (-3.82%) ⬇️
application-templates-parental-leave 24.95% <ø> (-0.36%) ⬇️
application-types 9.00% <ø> (-0.27%) ⬇️
application-ui-components 1.63% <ø> (+0.07%) ⬆️
application-ui-shell 23.80% <ø> (+0.50%) ⬆️
auth-admin-web 2.43% <ø> (ø)
auth-api-lib 8.18% <ø> (-1.37%) ⬇️
auth-nest-tools 24.62% <ø> (ø)
auth-react 24.95% <ø> (+1.80%) ⬆️
auth-shared 66.66% <ø> (-8.34%) ⬇️
clients-charge-fjs-v2 34.90% <ø> (-1.80%) ⬇️
clients-driving-license 38.72% <ø> (+0.15%) ⬆️
clients-driving-license-book 40.86% <ø> (+<0.01%) ⬆️
clients-financial-statements-inao 47.30% <ø> (+0.31%) ⬆️
clients-license-client ?
clients-middlewares 77.01% <ø> (+1.40%) ⬆️
clients-regulations 41.97% <ø> (+0.10%) ⬆️
clients-rsk-company-registry 29.29% <ø> (-0.22%) ⬇️
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 14.35% <ø> (-3.57%) ⬇️
clients-syslumenn 50.42% <ø> (+0.44%) ⬆️
clients-zendesk 55.26% <ø> (ø)
cms ?
cms-translations 39.57% <ø> (-0.05%) ⬇️
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.73% <ø> (ø)
dokobit-signing 58.33% <ø> (+0.59%) ⬆️
download-service 45.10% <ø> (-1.01%) ⬇️
email-service 61.42% <ø> (ø)
feature-flags 82.92% <ø> (-3.89%) ⬇️
file-storage 48.43% <ø> (+0.37%) ⬆️
financial-aid-backend 57.10% <ø> (-1.07%) ⬇️
financial-aid-shared 18.13% <ø> (ø)
icelandic-names-registry-backend 56.41% <ø> (-1.41%) ⬇️
infra-nest-server 43.20% <ø> (+0.28%) ⬆️
infra-tracing 43.24% <ø> (ø)
island-ui-core 29.92% <ø> (+0.65%) ⬆️
judicial-system-api 17.84% <ø> (+1.48%) ⬆️
judicial-system-audit-trail 65.10% <ø> (+0.75%) ⬆️
judicial-system-backend 57.36% <ø> (+0.23%) ⬆️
judicial-system-formatters 81.58% <ø> (-0.51%) ⬇️
judicial-system-message 64.33% <ø> (+0.44%) ⬆️
judicial-system-message-handler 62.37% <ø> (-1.09%) ⬇️
judicial-system-scheduler 54.86% <ø> (+0.55%) ⬆️
judicial-system-types 53.90% <ø> (-4.86%) ⬇️
judicial-system-web 22.99% <ø> (-0.53%) ⬇️
license-api 46.06% <ø> (+3.51%) ⬆️
localization 10.19% <ø> (+0.03%) ⬆️
logging 48.43% <ø> (ø)
message-queue 67.59% <ø> (ø)
nest-audit 67.26% <ø> (-0.95%) ⬇️
nest-config 76.61% <ø> (+1.28%) ⬆️
nest-feature-flags 48.85% <ø> (-0.17%) ⬇️
nest-problem 50.14% <ø> (-0.59%) ⬇️
nest-sequelize 94.44% <ø> (ø)
nest-swagger 53.75% <ø> (ø)
nova-sms 63.41% <ø> (ø)
portals-admin-regulations-admin 2.14% <ø> (-0.02%) ⬇️
portals-core 17.20% <ø> (+0.79%) ⬆️
reference-backend 55.17% <ø> (-1.22%) ⬇️
regulations 16.90% <ø> (ø)
residence-history 85.00% <ø> (ø)
service-portal-core 10.78% <ø> (+1.38%) ⬆️
service-portal-health 0.80% <ø> (+0.28%) ⬆️
service-portal-information 13.90% <ø> (-0.25%) ⬇️
services-auth-admin-api 50.73% <ø> (-1.46%) ⬇️
services-auth-delegation-api 58.90% <ø> (-0.19%) ⬇️
services-auth-ids-api 56.24% <ø> (-0.20%) ⬇️
services-auth-personal-representative 47.20% <ø> (-1.05%) ⬇️
services-auth-personal-representative-public 45.38% <ø> (-0.83%) ⬇️
services-auth-public-api 51.74% <ø> (-0.34%) ⬇️
services-documents 63.73% <ø> (-1.52%) ⬇️
services-endorsements-api 56.01% <ø> (-0.34%) ⬇️
services-sessions 63.71% <ø> (-0.24%) ⬇️
services-user-notification 26.29% <ø> (-0.14%) ⬇️
services-user-profile 66.08% <ø> (+7.60%) ⬆️
shared-components 29.33% <ø> (+0.92%) ⬆️
shared-form-fields 32.25% <ø> (+0.53%) ⬆️
shared-mocking 64.13% <ø> (-0.49%) ⬇️
shared-pii 92.85% <ø> (ø)
shared-problem 86.95% <ø> (ø)
shared-utils 26.61% <ø> (+0.56%) ⬆️
skilavottord-ws 25.64% <ø> (+0.10%) ⬆️
web 1.08% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1575 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e565fb5...9c51c1d. Read the comment docs.

@nx-cloud
Copy link

nx-cloud bot commented Aug 21, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b0a2ec3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@lodmfjord lodmfjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

infra/src/cli/cli.ts Outdated Show resolved Hide resolved
infra/src/cli/render-secrets.ts Outdated Show resolved Hide resolved
@andes-it
Copy link
Member

This PR's had a 15-day siesta. Lost its spark, did it? It's making an exit in 5 days unless the stale label disappears.

@andes-it andes-it added the stale Issue or pull request is stale label Nov 18, 2023
@andes-it
Copy link
Member

This PR closed its doors. Sat around for a day after the stale tag, then reckoned it's not worth the fuss.

@andes-it andes-it closed this Nov 23, 2023
@busla busla reopened this Feb 2, 2024
@andes-it andes-it removed the stale Issue or pull request is stale label Feb 3, 2024
@andes-it
Copy link
Member

This PR's had a 15-day siesta. Lost its spark, did it? It's making an exit in 5 days unless the stale label disappears.

@andes-it andes-it added stale Issue or pull request is stale and removed stale Issue or pull request is stale labels Feb 18, 2024
@andes-it
Copy link
Member

andes-it commented Mar 5, 2024

This PR's had a 15-day siesta. Lost its spark, did it? It's making an exit in 5 days unless the stale label disappears.

@andes-it andes-it added the stale Issue or pull request is stale label Mar 5, 2024
@andes-it
Copy link
Member

This PR closed its doors. Sat around for a day after the stale tag, then reckoned it's not worth the fuss.

@andes-it andes-it closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue or pull request is stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants