Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumps core at 4PM every day after eating entire heap #1129

Closed
rlees85 opened this issue Feb 29, 2024 · 23 comments
Closed

Dumps core at 4PM every day after eating entire heap #1129

rlees85 opened this issue Feb 29, 2024 · 23 comments

Comments

@rlees85
Copy link

rlees85 commented Feb 29, 2024

Describe the bug
As title says, around 4PM every day Teams for Linux will dump its core. This is also normally about 8 hours after I started it. The main symptom of this is Teams just disappears. You can only tell its a core dump by looking in the core dumps folder.

Its particularly annoying because the size of a Teams core dump is 600mb+ compressed so it soon starts eating disk without regular clearouts.

This has only started happening in the past month or so. It could be specific to me, my hardware and drivers but at this point I am just wanting to see if anyone else has noticed the same.

I have been using the "new" Teams, not sure if its relevant. I've reverted back to ye olde Teams and will report back if it solves it or not.

To Reproduce
Steps to reproduce the behavior:

  1. Open Teams
  2. Use Teams
  3. Wait about 8 hours (or 4PM) - 😆
  4. Teams dumps its core

Expected behavior
Teams not to dump its core.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Arch Linux
  • Installation package: AUR
  • Version: latest over the past month or so (I keep it up to date)

Additional context
Some nuggets from the logs:

Feb 29 16:06:51 teams-for-linux.desktop[35000]: <--- Last few GCs --->
Feb 29 16:06:51 teams-for-linux.desktop[35000]: [35000:0x1b20003e8000] 29058495 ms: Scavenge 3878.6 (4049.6) -> 3878.6 (4049.6) MB, 106.55 / 0.00 ms  (average mu = 1.000, current mu = 1.000) task;
Feb 29 16:06:51 teams-for-linux.desktop[35000]: [35000:0x1b20003e8000] 29058600 ms: Scavenge 3878.6 (4049.6) -> 3878.6 (4049.6) MB, 104.47 / 0.00 ms  (average mu = 1.000, current mu = 1.000) task;
Feb 29 16:06:51 teams-for-linux.desktop[35000]: [35000:0x1b20003e8000] 29058703 ms: Scavenge 3878.6 (4049.6) -> 3878.6 (4049.6) MB, 103.68 / 0.00 ms  (average mu = 1.000, current mu = 1.000) task;
Feb 29 16:06:51 teams-for-linux.desktop[35000]: <--- JS stacktrace --->
Feb 29 16:06:51 teams-for-linux.desktop[35000]: FATAL ERROR: NewSpace::EnsureCurrentCapacity Allocation failed - JavaScript heap out of memory

I could post the entire stack trace but probably no point since the reason looks fairly clear for the core dump.

@ChristoSnake
Copy link

I've noticed that it consumes more memory the longer it runs, but have not experienced core dumps as a result.

@rlees85
Copy link
Author

rlees85 commented Feb 29, 2024

using "new" teams @ChristoSnake ?

@ChristoSnake
Copy link

Yep...

This morning when I started it - 800 MB. Three hours later it's at 1.2 GB.

Latest of everything (kernel, KDE, Teams rpm, etc).

@rlees85
Copy link
Author

rlees85 commented Mar 1, 2024

I've tried reverting back to the old Teams and it seems to have stopped doing it. Meaning that this is at least specific only to the new Teams

@ChristoSnake
Copy link

I tested memory consumption on Teams v2 on Friday:

  • 09:00 = 0.8 GB
  • 12:00 = 1.2 GB
  • 18:00 = 4.6 GB!!

Back on Teams v1 today, repeating the tests...

@ChristoSnake
Copy link

Apologies, I updated to the latest v1.4.13 yesterday so I had to wait another day for measuring. Today's stats on Teams v1 are:

  • 09:00 = 0.7 GB
  • 17:00 = 1.0 GB

@jijojosephk
Copy link
Collaborator

I don't think we have much control here. Something to do with the new version of teams.

@rlees85
Copy link
Author

rlees85 commented Mar 11, 2024

As in you know or suspect? I'd be surprised if even Microsoft managed to drop the ball that badly. I'll try it in a browser tab perhaps for a day and see if it is happening there too. I suspected it would be a hook in Teams for Linux designed for the old version that is conflicting with something the new version is doing. Be hilarious if the new Teams does this even in the browser...

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Mar 12, 2024 via email

@rlees85
Copy link
Author

rlees85 commented Mar 22, 2024

Sorry I haven't got back. I've actually not been able to get Teams to work successfully at all in the browser as of yet.

I am actually getting to the point of refusing to use Teams at all.

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Mar 22, 2024 via email

@rlees85
Copy link
Author

rlees85 commented Mar 22, 2024

@IsmaelMartinez in my case, I am not seeing any memory leakage with Teams for Linux with classic Teams. It generally moves around from 800MB-1GB (up and down depending on activity). Its not a constant upward trajectory like Teams V2 is.

@IsmaelMartinez
Copy link
Owner

I have created a wee PR to see if this eases by removing a recurring call that will fail in react land, and that I don't think it does much in the angular land.

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Mar 22, 2024

Can you check if that leak goes away with this? https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.15.

Can ignore, I doubt that pre-release will fully work and might create more memory issues. See #1129 (comment)

@rlees85
Copy link
Author

rlees85 commented Mar 22, 2024

Will do , thanks for taking a look. If it doesn't, I'll have another go at getting Teams V2 to play in the browser (maybe next week though).

I could just leave it open over weekend but im not sure thats a good test (no activity)

@IsmaelMartinez
Copy link
Owner

I just realized is a bit bigger than just removing that file, but I will have a better look and see what I can do tonight, but I do suspect there can be a bit of a memory leak in that implementation if angular is not present. Just need to decide if to put the effort on fixing it for v2 or making the angular part more robust.

@IsmaelMartinez
Copy link
Owner

Ok, second try :) https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.15 I did a wee test one this one and memory seems stable, whoever only test it for a short period of time.

@rlees85
Copy link
Author

rlees85 commented Mar 23, 2024

All installed and new teams enabled for test on Monday

@ChristoSnake
Copy link

I've also installed and done a startup memory snapshot, will report back at the end of the day. I have a few meetings lined up, including some screen sharing ones.

@rlees85
Copy link
Author

rlees85 commented Mar 25, 2024

so far, Teams has not risen above ~800MB usage for me. Its 3PM UK and before changes it would have got to 4GB and core dumped at 4PM (so in just one more hour). So I would say its looking very good my end!

Thanks very much! You make Teams tolerable 😄

edit: it just GC'd or something, back down to 728MB. Looking extremely good.

@ChristoSnake
Copy link

Same here :-)

I've spent about five hours in meetings today, and it went from 0.7 GB this morning to around 1 GB now. This is waaaaaay better, thank you very much!

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Mar 26, 2024

I will see if I can release this today then. Thanks for testing it out!

@IsmaelMartinez
Copy link
Owner

Released now. Hopefully this gets rid of a few issues. I suspect you guys have been moved to "react" instead of angular, but I am still in angular :/ (so it doesn't fail for me). Closing the issue as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants