Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing docs for conditionalValid, compare operator, and other comments. #26

Merged
merged 3 commits into from
Jul 23, 2018
Merged

Add missing docs for conditionalValid, compare operator, and other comments. #26

merged 3 commits into from
Jul 23, 2018

Conversation

bmv437
Copy link
Contributor

@bmv437 bmv437 commented Jul 23, 2018 •
edited
Loading

What I did

Updated the docs to add missing docs for the conditionalValid prop, and the compare operator. I also elaborated on some other doc entries.

Fixes #25

PR Checklist

  • Formatted with prettier (yarn run format)

@ymukavozchyk
Copy link

In b1c4470 you might want to wrap "childFields" like childFields

@ymukavozchyk ymukavozchyk self-requested a review July 23, 2018 17:18
ymukavozchyk
ymukavozchyk approved these changes Jul 23, 2018
View reviewed changes
Copy link

@ymukavozchyk ymukavozchyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@bmv437 bmv437 merged commit fe14285 into master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwallisabc wwallisabc wwallisabc approved these changes

@ymukavozchyk ymukavozchyk ymukavozchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmv437 @ymukavozchyk @wwallisabc