Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically format the code #218

Closed
2 of 3 tasks
Guts opened this issue Aug 30, 2019 · 0 comments
Closed
2 of 3 tasks

Automatically format the code #218

Guts opened this issue Aug 30, 2019 · 0 comments
Assignees
@SimonSAMPERE
Labels
code art Qualité du code source wontfix Ne sera pas corrigé
Projects
Roadmap - plugin QGIS
Milestone
Not planned

Comments

@Guts
Copy link
Contributor

Guts commented Aug 30, 2019 •
edited by SimonSAMPERE

To ensure source code is respecting PEP8 and divine readability, there are two options:

  • indent manually and laboriously
  • use an automatic formatter, and black appears to be the recommended one

So:

  • install black as dev dependency
  • add formatting to the VSC settings
  • automate code formatting for each commit with pre-commit
@Guts Guts added code art Qualité du code source task labels Aug 30, 2019
@Guts Guts added this to the Version 2 milestone Aug 30, 2019
SimonSAMPERE added a commit that referenced this issue Sep 2, 2019
@SimonSAMPERE
first try formatting
334134b 
#218
SimonSAMPERE added a commit that referenced this issue Sep 4, 2019
@SimonSAMPERE
test to fix vscode git locating
7c86a12 
#218
SimonSAMPERE added a commit that referenced this issue Sep 4, 2019
@SimonSAMPERE
test auto format isogeo.py
c4f702a 
#218
SimonSAMPERE added a commit that referenced this issue Sep 4, 2019
@SimonSAMPERE
config format
042ebd6 
#218
SimonSAMPERE added a commit that referenced this issue Sep 4, 2019
@SimonSAMPERE
test auto format
1de87e2 
#218
SimonSAMPERE added a commit that referenced this issue Sep 4, 2019
@SimonSAMPERE
test auto format 3
eef73bb 
#218
SimonSAMPERE added a commit that referenced this issue Sep 4, 2019
@SimonSAMPERE
format with black
577dbfd 
#218
@SimonSAMPERE SimonSAMPERE mentioned this issue Sep 4, 2019
Merged
Guts pushed a commit that referenced this issue Sep 11, 2019
@SimonSAMPERE @Guts
Code formatting (#222)
f4f28d1 
* format with black #218
Guts added a commit that referenced this issue Sep 12, 2019
@Guts
massive black formatting, completing #218
b930f52
@SimonSAMPERE SimonSAMPERE modified the milestones: Version 2, Not planned Oct 23, 2019
@SimonSAMPERE SimonSAMPERE added the wontfix Ne sera pas corrigé label Oct 25, 2019
@SimonSAMPERE SimonSAMPERE added this to Done - Fait in Roadmap - plugin QGIS Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonSAMPERE SimonSAMPERE

Labels
code art Qualité du code source wontfix Ne sera pas corrigé
Projects
No open projects
Roadmap - plugin QGIS
Delivered (production)
Milestone
Not planned
Development

No branches or pull requests
2 participants
@Guts @SimonSAMPERE