Update api requesting issue catching #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch other error codes
better error catcher
SimonSAMPERE
added
bug
SimonSAMPERE
changed the title
Guts
approved these changes
Oct 21, 2019
Comment on lines
-75
to
+76
| if len(words) == 1 and len(words[0]) > 33: | ||
| final_text = "\n" + words[0][:30] + "..." | ||
| if len(words) == 1 and len(words[0]) > 22: | ||
| final_text = "\n" + words[0][:19] + "..." |
There was a problem hiding this comment.
à quel ticket cette modif est-elle liée ?
| " in 'Preferences/Options/Network'.", | ||
| context=__class__.__name__, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
Plusieurs choses :
- l'alerte est contraire à ce qui est indiqué dans la docstring. Déclenche t'on une erreur s'il y a un proxy sur l'OS mais dans QGIS ? ou l'inverse ? ou les deux ?
- seul HTTP est testé alors que l'API fonctionne essentiellement en HTTPS. Certes, les proxy gèrent cependant souvent les 2 protocoles sur la même URL mais pourquoi ne pas tester ?
- de plus comme indiqué sur Slack, cela ne teste que la case cochée ou pas. Or, dans QGIS, la case peut être cochée (donc test=True) mais indiquer d'utiliser le proxy OS (DefaultProxy) https://docs.qgis.org/testing/en/docs/user_manual/introduction/qgis_configuration.html#network-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the #266 bug investigation.
In case of a problem with the response of the Isogeo API, the error code Qt and the status code http are written in the logs. The objective is to identify more different causes of error.
Bonus : close #273 by replacing
typeswithdatatype