-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checkout, clone, push): Add 'onPrePush' and 'onPostCheckout' #1797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
Sorry for late reply. Did you change something? I didn't get any notification from GitHub. And you didn't reply to my comments. |
Yes, I applied changes that you suggested. Sorry, it probably my fault, I expected that re-requesting a review will send you a notification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry for late response, I totally forget about this Review. I've found my old notes where I did add a link to the PR.
Looks good.
🎉 This PR is included in version 1.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm adding a parameter to an existing command X:
src/api/X.js
(andsrc/commands/X.js
if necessary)__tests__/test-X.js
if possiblenpm run add-contributor
and follow the prompts to add yourself to the READMEwebsite/sidebars.json
Closes #1186
I added new documentation
website/sidebars.json
, but I don't know how to handle versioned variants of documentation.