[feat:stash] add stash API for push, apply, pop, drop, list and clean #228 #980 #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isomorphic-git#1045) BREAKING CHANGE: The `newSubmoduleBehavior` parameter has been removed and is now the default and only behavior, because it is good. And the `noSubmodules` parameter has been removed and is also the default and only behavior. (This only affects you if you a) liked seeing the console warnings or b) were using `statusMatrix` to traverse submodules for some reason.)
BREAKING CHANGE: The `verify` function has been removed, and the `signature` property of TagObject renamed to `gpgsig` to match CommitObject. Since `log`, `readCommit`, and `readTag` all include the `gpgsig` and signing `payload` in their return values now, it is simpler and more efficient to do the verification outside of `isomorphic-git`. See the documentation for the `onSign` parameter for complete code examples.
…ic-git#1050) BREAKING CHANGE: The URL that's provided is now the URL that's used; no longer will they be "fixed" to end with `.git` since sometimes that actually makes things worse, and subverts user expectations. Accordingly, the `noGitSuffix` parameter has been removed since it's the default behavior. Furthermore, the `User-Agent` is now totally in the user's hands, because it is just a minefield, and I'm done trying to make sense of it. I added a Headers page to the docs documenting what I know about User-Agent + GitHub + CORS + Chrome bugs.
…en`, and `oauth2format` (isomorphic-git#1051) BREAKING CHANGE: The `username`, `password`, `token`, and `oauth2format` params were removed and replaced with the `onAuth` callback. Since `onAuth` also replaced the `credentialManager` plugin, this means now there is a single way to do authentication instead of two.
…t#1052) BREAKING CHANGE: The `author.date`, `committer.date`, `tagger.date` parameters were removed in favor of `author.timestamp`, `comitter.timestamp`, `tagger.timestamp` in order to be clear about what is actually written and better reflect the return types in `readCommit`, `log`, and `readTag`.
… before continuing
…a non-existing branch (isomorphic-git#1055)
…s retry, canceling (isomorphic-git#1054) BREAKING CHANGE: The `token` and `oauth2format` properties have been removed from the GitAuth interface, which makes it much simpler and and eliminates a dozen GitErrors handling specific edge cases. A `headers` property has been added to the GitAuth interface. This makes `onAuth` much more powerful because you can inject whatever HTTP headers you want. The `onAuthFailed` callback now lets you return a GitAuth object. This means you can keep retrying to authenticate as many times as you like. A `cancel` property has been added to the GitAuth interface. This means you gracefully give up authenticating and the function will throw an E.UserCancelledError instead of an E.HTTPError.
BREAKING CHANGE: `E` has been removed and replaced by `Errors`. The errors are typed so if you use an `instanceof` comparison in the `catch` statement, auto-completion on their `.data` property works. There are fewer errors total, they have shorter names, and thus the resulting gzip bundle is smaller despite the addition of 28 new classes. Lastly, the distinction between `Fail` and `Error` has been removed since it was subjective. Here's the complete breakdown of which `Errors` classes replaced which `E` codes: - `AlreadyExistsError` replaces `AddingRemoteWouldOverwrite`, `NoteAlreadyExistsError`, `RefExistsError` - `AmbiguousError` replaces `AmbiguousShortOid` - `CheckoutConflictError` replaces `CheckoutConflictError` - `CommitNotFetchedError` replaces `CommitNotFetchedError` - `EmptyServerResponseError` replaces `EmptyServerResponseFail` - `FastForwardError` replaces `FastForwardFail` - `GitPushError` replaces `GitPushError` - `HttpError` replaces `HTTPError` - `InternalError` replaces `InternalFail` - `InvalidFilepathError` replaces `DirectorySeparatorsError` - `InvalidOidError` replaces `CorruptShallowOidFail`, `NotAnOidFail` - `InvalidRefNameError` replaces `InvalidRefNameError` - `MaxDepthError` replaces `MaxSearchDepthExceeded` - `MergeNotSupportedError` replaces `MergeNotSupportedFail` - `MissingNameError` replaces `MissingAuthorError`, `MissingCommitterError`, `MissingTaggerError` - `MissingParameterError` replaces `MissingRequiredParameterError` - `NoRefspecError` replaces `NoRefspecConfiguredError` - `NotFoundError` replaces `ExpandRefError`, `FileReadError`, `GitRootNotFoundError`, `ReadObjectFail`, `RefNotExistsError`, `ResolveRefError`, `ShortOidNotFound`, `TreeOrBlobNotFoundError` - `ObjectTypeError` replaces `DirectoryIsAFileError`, `ObjectTypeAssertionFail`, `ObjectTypeAssertionInPathFail`, `ObjectTypeAssertionInTreeFail`, `ObjectTypeUnknownFail`, `ResolveCommitError`, `ResolveTreeError` - `ParseError` replaces `AssertServerResponseFail`, `UnparseableServerResponseFail` - `PushRejectedError` replaces `PushRejectedNonFastForward`, `PushRejectedTagExists` - `RemoteCapabilityError` replaces `RemoteDoesNotSupportDeepenNotFail`, `RemoteDoesNotSupportDeepenRelativeFail`, `RemoteDoesNotSupportDeepenSinceFail`, `RemoteDoesNotSupportShallowFail` - `SmartHttpError` replaces `RemoteDoesNotSupportSmartHTTP` - `UnknownTransportError` replaces `UnknownTransportError` - `UrlParseError` replaces `RemoteUrlParseError` - `UserCanceledError` replaces `UserCancelledError` The following error codes are no longer used / have no equivalent: `AcquireLockFileFail`, `BranchDeleteError`, `CoreNotFound`, `DoubleReleaseLockFileFail`, `InvalidDepthParameterError`, `InvalidParameterCombinationError`, `MismatchRefValueError`, `NoHeadCommitError`, `NotImplementedFail`, `ObjectTypeAssertionInRefFail`, `PluginSchemaViolation`, `PluginUndefined`, `PluginUnrecognized`
1 task
Open
|
Please rebase, the filing test got disabled. |
* docs: add @alexvy86 as a contributor * Add locking to fix race condition reading/writing refs * Make prettier happy * Encapsulate locking logic * Use withLock helper * Indicate private functions * Remove obsolete variable declaration * Await all uses of RefLock.withLock * Unit test * Unit test * Use async-lock package * Fix tree-shaking
|
rebase pushed |
|
Thanks, I will need to test the feature locally before merging. This is a big feature I want to make sure it works correctly. Will do this probably tomorrow and will take a closer look at the code. I'm not sure if the tests pass now. I'm using a mobile GitHub app. |
) Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.1...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… drop, list and clear, plus 18 test cases
…somorphic-git#980, also add more test cases for changes and deletion under a folder
|
There are some failing tests, you need to figure that out before this will be merged. I'm not sure what is the issue, but failing tests are for git stash. |
|
tests with Jest are all good, only Karma fails. It's caused by |
|
#1898 replaces this one for a cleaner history, build and test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a new command: stash
src/api(andsrc/commandsif necessary)src/index.js__tests__/test-exports.jssrc/__tests__- test-stash covers 22 test caseswebsite/sidebars.jsonwebsite/versioned_sidebars/version-1.x-sidebars.jsonnpm run add-contributorand follow the prompts to add yourself to the README