Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow #1902

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Workflow #1902

wants to merge 3 commits into from

Conversation

jcubic
Copy link
Contributor

@jcubic jcubic commented Apr 21, 2024

Another attempt to merge GitHub workflow to main.

I'm fixing a bug or typo

  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "fix: [Description of fix]"

I'm adding a parameter to an existing command X:

  • add parameter to the function in src/api/X.js (and src/commands/X.js if necessary)
  • document the parameter in the JSDoc comment above the function
  • add a test case in __tests__/test-X.js if possible
  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "feat(X): Added 'bar' parameter"

I'm adding a new command:

  • add as a new file in src/api (and src/commands if necessary)
  • add command to src/index.js
  • update __tests__/test-exports.js
  • create a test in src/__tests__
  • document the command with a JSDoc comment
  • add page to the Docs Sidebar website/sidebars.json
  • add page to the v1 Docs Sidebar website/versioned_sidebars/version-1.x-sidebars.json
  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "feat: Added 'X' command"

@jcubic jcubic mentioned this pull request Apr 21, 2024
16 tasks
@jcubic
Copy link
Contributor Author

jcubic commented Apr 21, 2024

@seanpoulter can you check why the tests are failing?

@seanpoulter
Copy link
Contributor

Could you please try again @isomorphic-git-bot?

@jcubic
Copy link
Contributor Author

jcubic commented Jul 29, 2024

The bot doesn't work anymore, I think it was using prettier to fix the code, but it don't do this anymore.

@jcubic
Copy link
Contributor Author

jcubic commented Jul 29, 2024

If you updated your branch (from a fork) I will need to merge the changes.

@seanpoulter
Copy link
Contributor

The bot doesn't work anymore, I think it was using prettier to fix the code, but it don't do this anymore.

Ah, we probably need to grant it permissions to modify the content.

@jcubic
Copy link
Contributor Author

jcubic commented Jul 31, 2024

The bot doesn't work anymore, I think it was using prettier to fix the code, but it don't do this anymore.

Ah, we probably need to grant it permissions to modify the content.

I don't even know where to look at for that bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants