Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: statusMatrix() should not show non-files #706

Merged
merged 3 commits into from
Mar 27, 2019
Merged

fix: statusMatrix() should not show non-files #706

merged 3 commits into from
Mar 27, 2019

Conversation

katakonst
Copy link
Contributor

I'm fixing a bug or typo

fixes #705

@karma-pr-reporter
Copy link

Test Results for 0dd2ee6:

Browser Passed Skipped Failed Time Disconnected Error
HeadlessChrome 0.0.0 (Linux 0.0.0) 252 1 0 1 min 21.213 secs false undefined
Firefox 65.0.0 (Ubuntu 0.0.0) 251 1 1 2 mins 34.741 secs false undefined
Chrome Mobile 67.0.3396 (Android 7.1.1) 0 0 0 4 mins 30.022 secs true undefined
Safari 11.1.2 (Mac OS X 10.13.6) 0 0 0 4 mins 53.811 secs true undefined
Mobile Safari 11.0.0 (iOS 11.2.0) 0 0 0 6 mins 54.747 secs true undefined
Edge 17.17134.0 (Windows 10 0.0.0) 0 0 0 7 mins 30.108 secs true undefined

@karma-pr-reporter
Copy link

Test Results for 0dd2ee6:

Browser Passed Skipped Failed Time Disconnected Error
Firefox 65.0.0 (Ubuntu 0.0.0) 251 1 1 1 min 56.989 secs false undefined
Safari 11.1.2 (Mac OS X 10.13.6) 252 1 0 3 mins 7.851 secs false undefined
Chrome Mobile 67.0.3396 (Android 7.1.1) 252 1 0 3 mins 27.538 secs false undefined
Edge 17.17134.0 (Windows 10 0.0.0) 252 1 0 5 mins 29.258 secs false undefined
Mobile Safari 11.0.0 (iOS 11.2.0) 199 1 0 5 mins 54.538 secs true undefined

@billiegoose
Copy link
Member

Thank you so much!!!

@karma-pr-reporter
Copy link

Test Results for 9f63693:

Browser Passed Skipped Failed Time Disconnected Error
HeadlessChrome 0.0.0 (Linux 0.0.0) 253 1 0 1 min 25.478 secs false undefined
Firefox 65.0.0 (Ubuntu 0.0.0) 252 1 1 2 mins 41.964 secs false undefined
Safari 11.1.2 (Mac OS X 10.13.6) 253 1 0 3 mins 25.997 secs false undefined
Chrome Mobile 67.0.3396 (Android 7.1.1) 253 1 0 3 mins 47.698 secs false undefined
Mobile Safari 11.0.0 (iOS 11.2.0) 253 1 0 5 mins 3.648 secs false undefined
Edge 17.17134.0 (Windows 10 0.0.0) 253 1 0 5 mins 55.544 secs false undefined

@karma-pr-reporter
Copy link

Test Results for 9f63693:

Browser Passed Skipped Failed Time Disconnected Error
Firefox 65.0.0 (Ubuntu 0.0.0) 252 1 1 1 min 59.117 secs false undefined

@karma-pr-reporter
Copy link

Test Results for e537bbc:

Browser Passed Skipped Failed Time Disconnected Error
Firefox 65.0.0 (Ubuntu 0.0.0) 253 1 0 2 mins 43.512 secs false undefined
HeadlessChrome 0.0.0 (Linux 0.0.0) 157 0 0 2 mins 48.59 secs true undefined
Safari 11.1.2 (Mac OS X 10.13.6) 253 1 0 3 mins 0.62 secs false undefined
Mobile Safari 11.0.0 (iOS 11.2.0) 253 1 0 3 mins 46.776 secs false undefined
Chrome Mobile 67.0.3396 (Android 7.1.1) 253 1 0 5 mins 4.953 secs false undefined
Edge 17.17134.0 (Windows 10 0.0.0) 253 1 0 5 mins 29.728 secs false undefined

@billiegoose
Copy link
Member

Hmm. The PR comment reporter didn't fire for the second go-round of HeadlessChrome but the log says it did pass:

 - HeadlessChrome 0.0.0 (Linux 0.0.0): 254 tests
   - 253 ok, 1 skipped

@billiegoose billiegoose merged commit ae230ae into isomorphic-git:master Mar 27, 2019
@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 0.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
@katakonst @billiegoose
feat: statusMatrix() should skip over "exotic" file types (sockets, f…
cdb70fc 
…ifos, etc) (isomorphic-git#706)

Note: I'm labeling this a `feat` rather than a `fix` because of a subtle possibly breaking change: we now call `.isFile()` on stat objects, so mixing this version of isomorphic-git with filesystems that don't implement `Stat.isFile()` (such as LightningFS < v3.0.0) might cause throw errors. Isomorphic-git has never stated exactly how much of the `Stat` API needs to be implemented to be compatible, mostly because I'm still figuring that out as more exotic edge cases (like sockets) are uncovered. Node fs, BrowserFS, and LightningFS >= v3.0.0 should all be unaffected by this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statusMatrix() shows non-files
4 participants
@katakonst @karma-pr-reporter @billiegoose @isomorphic-git-bot