-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make library compilable for Native Dart #39
base: master
Are you sure you want to change the base?
Conversation
In fact, I don't know how to test a flutter library until I met this post. So, I made a new working update. New registration way: import 'package:pwa/client.dart' as pwa;
void main() async {
// register PWA ServiceWorker for offline caching.
pwa.Client.create();
// ...
} |
I think this is going in the right direction, but I still would like to request a few refactor changes:
I think the first few are just quick mechanic changes, maybe the last point will be a bit more work, but after that this is ready to go. |
Ok captin, let's made a checklist for this. |
New registration way now is: import 'package:pwa/pwa.dart' as pwa;
void main() async {
// register PWA ServiceWorker for offline caching.
pwa.Client.create();
// ...
} |
…le-method abstract class, no need for it).
New registration way now is: import 'package:pwa/pwa.dart';
void main() async {
// register PWA ServiceWorker for offline caching.
createPwaClient();
// ...
} |
…ing change's scope).
I think this can now be bumped up then we can update the examples easily. |
Any updates on this? |
#38 #32