Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation documentation for OKD #48

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

learnitall
Copy link
Contributor

This commit ports installation instructions from the Cilium documentation and adds it to a local file. This is part of an effort to restructure OpenShift documentation within Cilium's documentation, after the deprecation of cilium/cilium-olm. See cilium/cilium#24270.

Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good assuming the instructions still work 👍 just one minor nit about including a file that does not exist

Deploy the connectivity test
----------------------------

.. include:: kubectl-connectivity-test.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this won't work because kubectl-connectivity-test.rst doesn't exist

@learnitall
Copy link
Contributor Author

Hey @michi-covalent, my apologies for losing track of this. I updated the instructions to point to the Cilium documentation on for running the connectivity test, so we don't have to copy the snippet over.

This commit ports installation instructions from the Cilium
documentation and adds it to a local file. This is part of an effort to
restructure OpenShift documentation within Cilium's documentation, after
the deprecation of cilium/cilium-olm. See cilium/cilium#24270.

The ported documentation includes a snippet containing information
on how to run the connectivity test suite. As this snippet is not
available in this repository, and to prevent having to keep two
duplicate sources of information up-to-date, the ported documentation
has been modified to point to Cilium's troubleshooting guide, which
contains instructions for running the connectivity tests.

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
@learnitall learnitall force-pushed the pr/learnitall/add-install-docs branch from d7a65db to 80bb21d Compare January 22, 2024 18:54
@michi-covalent michi-covalent merged commit a48fa03 into main Jan 22, 2024
3 checks passed
@michi-covalent michi-covalent deleted the pr/learnitall/add-install-docs branch January 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants