Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename orbi_calculate_ratios? #11

Closed
sebkopf opened this issue May 26, 2023 · 1 comment
Closed

rename orbi_calculate_ratios? #11

sebkopf opened this issue May 26, 2023 · 1 comment

Comments

@sebkopf
Copy link
Contributor

sebkopf commented May 26, 2023

Should this be renamed to orbi_calculate_ratio() as it does calculate a single value ratio?
@123caj
Copy link
Collaborator

123caj commented May 26, 2023

I think you are correct. well spotted! Before the current implementation the function was working on a column I believe and would calculate 1 to many ratios. Now grouping is done outside the function (e.g. in orbi_summarize_results(), if I remember correctly

sebkopf added a commit that referenced this issue Jun 14, 2023
@sebkopf
rename orbi_calculate_ratios - close #11
70f3f41 
deprecated message in the old function so existing code is backwards compatible
@sebkopf sebkopf closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@123caj @sebkopf