Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postbox now appended after the comments #815

Closed
Kerumen opened this issue Mar 18, 2022 · 3 comments · Fixed by #820
Closed

Postbox now appended after the comments #815

Kerumen opened this issue Mar 18, 2022 · 3 comments · Fixed by #820
Labels
bug client (Javascript) client code and CSS
Milestone

Comments

@Kerumen
Copy link

Kerumen commented Mar 18, 2022

Since this PR, the postbox is now appended after all the comments which is a bit annoying if you have a lot of comments. It was better to append it before the isso-root (<div id="isso-root"></div>) to enable easy commenting from the users.

@adroste
Copy link

adroste commented Mar 19, 2022

Same here. Super annoying.

jQuery workaround:

// Workaround isso issue: https://github.com/posativ/isso/issues/815
$( "<style>#isso-thread { display: table; } #isso-root { display: table-footer-group; }</style>" ).appendTo( "head" );

@Kerumen
Copy link
Author

Kerumen commented Mar 20, 2022

CSS workaround:

#isso-thread {
  display: flex;
  flex-direction: column;
}

#isso-thread h4 {
  order: 1;
}

#isso-thread .isso-postbox {
  order: 2;
  width: 100%;
}

#isso-thread #isso-root {
  order: 3;
}

ix5 added a commit to ix5/isso that referenced this issue Mar 20, 2022
This restores the behavior before isso-comments#311

Closes isso-comments#815

Note: This is only a hotfix!
ix5 added a commit that referenced this issue Mar 20, 2022
This is a backport of #820 to the 0.12.6 release branch.

This restores the behavior before #311

Closes #815

Note: This is only a hotfix!
@ix5
Copy link
Member

ix5 commented Mar 20, 2022

Thank you for reporting this issue. I have tagged 0.12.6.1 and uploaded a hotfix release to PyPi.

While I'm glad this regression was reported, it would have been better for all parties involved if someone had tested and reported this issue before release.

I've pushed a PR of the fix as #820, but we should revisit the way the client code constructs the core postbox and comment elements since we're now much more dependent on the calls to fetch config from the server before rendering anything.
This piece of documentation is also no longer 100% accurate.

@ix5 ix5 closed this as completed Mar 20, 2022
@ix5 ix5 added this to the 0.12.6 milestone Mar 20, 2022
@ix5 ix5 added client (Javascript) client code and CSS bug labels Mar 20, 2022
ix5 added a commit that referenced this issue Mar 21, 2022
This restores the behavior before #311

Closes #815

Note: This is only a hotfix!
vincentbernat pushed a commit to vincentbernat/isso that referenced this issue Nov 4, 2022
This is a backport of isso-comments#820 to the 0.12.6 release branch.

This restores the behavior before isso-comments#311

Closes isso-comments#815

Note: This is only a hotfix!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug client (Javascript) client code and CSS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants