-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postbox now appended after the comments #815
Comments
Same here. Super annoying. jQuery workaround:
|
CSS workaround: #isso-thread {
display: flex;
flex-direction: column;
}
#isso-thread h4 {
order: 1;
}
#isso-thread .isso-postbox {
order: 2;
width: 100%;
}
#isso-thread #isso-root {
order: 3;
} |
This restores the behavior before isso-comments#311 Closes isso-comments#815 Note: This is only a hotfix!
Thank you for reporting this issue. I have tagged 0.12.6.1 and uploaded a hotfix release to PyPi. While I'm glad this regression was reported, it would have been better for all parties involved if someone had tested and reported this issue before release. I've pushed a PR of the fix as #820, but we should revisit the way the client code constructs the core postbox and comment elements since we're now much more dependent on the calls to fetch config from the server before rendering anything. |
This is a backport of isso-comments#820 to the 0.12.6 release branch. This restores the behavior before isso-comments#311 Closes isso-comments#815 Note: This is only a hotfix!
Since this PR, the postbox is now appended after all the comments which is a bit annoying if you have a lot of comments. It was better to append it before the
isso-root
(<div id="isso-root"></div>
) to enable easy commenting from the users.The text was updated successfully, but these errors were encountered: