isso: js: embed: Insert Postbox before comments #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the behavior before isso-comments#311 Closes isso-comments#815 Note: This is only a hotfix!
Kerumen
approved these changes
Mar 21, 2022
vincentbernat
pushed a commit
to vincentbernat/isso
that referenced
this pull request
Nov 4, 2022
This is a backport of isso-comments#820 to the 0.12.6 release branch. This restores the behavior before isso-comments#311 Closes isso-comments#815 Note: This is only a hotfix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the behavior before #311
Closes #815
Note: This is only a hotfix!
Issue
We should revisit the way the client code constructs the core postbox and comment elements since we're now much more dependent on the calls to fetch config from the server before rendering anything.
This piece of documentation is also no longer 100% accurate.