css, js: Prefix all directives with 'isso-' #816
Conversation
|
cc @mycahp |
|
@ix5 This is definitely a breaking change regarding custom overrides. So anything below v0.13 could lead to mad users. |
|
Would you mind going over the change and testing whether I missed anything or fat-fingered some string? |
|
Looks good (without testing it locally). At first I thought you missed the input form selectors, but they are limited by the postbox scope. Nevertheless, you could also prefix the keys for the items that are persisted in the localstorage: |
That's a great catch, thank you! Moving to prefixed key names will ofc invalidate any username/email/website users have set, but imo it's not worth to write a migration for that. (Note that I hope you just happened to review the version I pushed after I rebased it on #822 ;-) |
This way, they are not interfering with other elements on the "host" page. Note that the LocalStorage is scoped inside the page isso is embedded on, not its API endpoint. Suggested by @adroste in isso-comments#816 (comment) Thanks!
|
Looks good! Without testing. But this will be a great improvement of the library :) |
This "namespaces" Isso's CSS in order not to conflict with things on page Fixes isso-comments#442
Prepending `isso-` to the element classes causes a change in the generated HTML and necessitates an update of the snapshot.
This way, they are not interfering with other elements on the "host" page. Note that the LocalStorage is scoped inside the page isso is embedded on, not its API endpoint. Suggested by @adroste in isso-comments#816 (comment) Thanks!
This "namespaces" Isso's CSS in order not to conflict with things on page
Fixes #442